From 06ef1e131b27b0f397cc615c96d51bede7050423 Mon Sep 17 00:00:00 2001 From: Marcin Lyda Date: Mon, 14 Mar 2022 14:33:42 +0100 Subject: [PATCH] [MOS-300] Remove unused variables Remove unused variables from PVS Studio analysis --- module-bluetooth/Bluetooth/interface/profiles/A2DP/A2DP.cpp | 3 +-- module-services/service-audio/AudioServiceAPI.cpp | 3 +-- module-services/service-cellular/NetworkSettings.cpp | 3 +-- .../models/alarm_settings/AlarmSettingsModel.cpp | 1 - .../models/alarm_settings/PrewakeUpSettingsModel.cpp | 3 +-- .../models/alarm_settings/SnoozeSettingsModel.cpp | 3 +-- products/BellHybrid/apps/common/src/models/BedtimeModel.cpp | 3 +-- 7 files changed, 6 insertions(+), 13 deletions(-) diff --git a/module-bluetooth/Bluetooth/interface/profiles/A2DP/A2DP.cpp b/module-bluetooth/Bluetooth/interface/profiles/A2DP/A2DP.cpp index e7b8de9d48a1ef5c5da9b482ac55d9e3e06828b4..2eb0257474cfdf205fe8a36cb933d882a75ddbf6 100644 --- a/module-bluetooth/Bluetooth/interface/profiles/A2DP/A2DP.cpp +++ b/module-bluetooth/Bluetooth/interface/profiles/A2DP/A2DP.cpp @@ -1,4 +1,4 @@ -// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. +// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved. // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md // @@ -329,7 +329,6 @@ namespace bluetooth a2dp_subevent_signaling_connection_established_get_bd_addr(packet, address); cid = a2dp_subevent_signaling_connection_established_get_a2dp_cid(packet); status = a2dp_subevent_signaling_connection_established_get_status(packet); - std::string deviceAddress{bd_addr_to_str(address)}; if (status != ERROR_CODE_SUCCESS) { LOG_INFO("A2DP Source: Connection failed, status 0x%02x, cid 0x%02x, a2dp_cid 0x%02x \n", status, diff --git a/module-services/service-audio/AudioServiceAPI.cpp b/module-services/service-audio/AudioServiceAPI.cpp index 394acac349946c8e4389995d6534cd77217deec7..062d36fdef9b8cbbf4070aea528382abbb17c48e 100644 --- a/module-services/service-audio/AudioServiceAPI.cpp +++ b/module-services/service-audio/AudioServiceAPI.cpp @@ -1,4 +1,4 @@ -// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. +// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved. // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md #include @@ -221,7 +221,6 @@ namespace AudioServiceAPI std::optional GetVolume(sys::Service *serv, audio::PlaybackType playbackType) { - std::optional volume; try { return static_cast(std::stoi(GetSetting(serv, audio::Setting::Volume, playbackType))); } diff --git a/module-services/service-cellular/NetworkSettings.cpp b/module-services/service-cellular/NetworkSettings.cpp index 5b89b1b1bc112d5659b6d414f8dce8425c1ab1b7..6a4ce4aff1f583811729f9168dd64215bb4bdab1 100644 --- a/module-services/service-cellular/NetworkSettings.cpp +++ b/module-services/service-cellular/NetworkSettings.cpp @@ -1,4 +1,4 @@ -// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. +// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved. // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md #include "NetworkSettings.hpp" @@ -260,7 +260,6 @@ at::Result::Code NetworkSettings::setPreferredSMSDomain(SMSDomainPreference pref at::Result::Code NetworkSettings::setIMSState(at::response::qcfg_ims::IMSState state) { - std::vector operatorNames; auto channel = cellularService.cmux->get(CellularMux::Channel::Commands); if (!channel) { return at::Result::Code::ERROR; diff --git a/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/AlarmSettingsModel.cpp b/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/AlarmSettingsModel.cpp index fd5beb98778d09ef800a23e484210699d34b8ab9..94f1a57c2a2fd6e165a49886563aa05eff0e885d 100644 --- a/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/AlarmSettingsModel.cpp +++ b/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/AlarmSettingsModel.cpp @@ -20,7 +20,6 @@ namespace app::bell_settings void AlarmVolumeModel::setValue(std::uint8_t value) { - const auto valStr = std::to_string(value); audioModel.setVolume(value, AbstractAudioModel::PlaybackType::Alarm, {}); } diff --git a/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/PrewakeUpSettingsModel.cpp b/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/PrewakeUpSettingsModel.cpp index 2d749d1fa31f2ccbee00c4098f451121c61a7ba6..cd65fe12850684994e840edba1ca6488e27d665e 100644 --- a/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/PrewakeUpSettingsModel.cpp +++ b/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/PrewakeUpSettingsModel.cpp @@ -1,4 +1,4 @@ -// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. +// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved. // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md #include @@ -32,7 +32,6 @@ namespace app::bell_settings void PrewakeUpChimeVolumeModel::setValue(std::uint8_t value) { - const auto valStr = std::to_string(value); audioModel.setVolume(value, AbstractAudioModel::PlaybackType::PreWakeup, {}); } diff --git a/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/SnoozeSettingsModel.cpp b/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/SnoozeSettingsModel.cpp index e1be32958bd20e6e95a7fc9c0b9d9abb431d5d62..c444ffd255077232e6bbe7095e9563c812e0b135 100644 --- a/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/SnoozeSettingsModel.cpp +++ b/products/BellHybrid/apps/application-bell-settings/models/alarm_settings/SnoozeSettingsModel.cpp @@ -1,4 +1,4 @@ -// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. +// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved. // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md #include @@ -73,7 +73,6 @@ namespace app::bell_settings void SnoozeChimeVolumeModel::setValue(std::uint8_t value) { - const auto valStr = std::to_string(value); audioModel.setVolume(value, AbstractAudioModel::PlaybackType::Snooze, {}); } diff --git a/products/BellHybrid/apps/common/src/models/BedtimeModel.cpp b/products/BellHybrid/apps/common/src/models/BedtimeModel.cpp index 6797dc1cc438878a3f40243a9f64510d987e1b52..b9ddec76ba90710d33f6e984652ea2c54fe64f9f 100644 --- a/products/BellHybrid/apps/common/src/models/BedtimeModel.cpp +++ b/products/BellHybrid/apps/common/src/models/BedtimeModel.cpp @@ -1,4 +1,4 @@ -// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. +// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved. // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md #include "models/BedtimeModel.hpp" @@ -77,7 +77,6 @@ namespace app::bell_bedtime void BedtimeVolumeModel::setValue(std::uint8_t value) { - const auto valStr = std::to_string(value); audioModel.setVolume(value, AbstractAudioModel::PlaybackType::Bedtime, {}); }