~aleteoryx/muditaos

20bedafcc86a82345eaf1bbc37a73ac31c93daae — Lefucjusz 3 years ago 40c628f
[MOS-863] Fix phonebook crash when adding country prefix

Fix of the issue that editing existing contact's
number by adding country prefix resulted in
PureOS crash due to application stack overflow.
Additionally moved misplaced changelog entry.
M module-apps/application-phonebook/include/application-phonebook/ApplicationPhonebook.hpp => module-apps/application-phonebook/include/application-phonebook/ApplicationPhonebook.hpp +2 -2
@@ 1,4 1,4 @@
// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved.
// Copyright (c) 2017-2023, Mudita Sp. z.o.o. All rights reserved.
// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md

#pragma once


@@ 28,7 28,7 @@ namespace gui::window::name
namespace app
{
    inline constexpr auto name_phonebook         = "ApplicationPhonebook";
    constexpr std::uint16_t phonebook_stack_size = 4096;
    constexpr std::uint16_t phonebook_stack_size = 1024 * 5;

    class ApplicationPhonebook : public app::Application
    {

M module-apps/application-phonebook/widgets/InputLinesWithLabelWidget.cpp => module-apps/application-phonebook/widgets/InputLinesWithLabelWidget.cpp +2 -2
@@ 1,4 1,4 @@
// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved.
// Copyright (c) 2017-2023, Mudita Sp. z.o.o. All rights reserved.
// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md

#include "InputLinesWithLabelWidget.hpp"


@@ 185,7 185,7 @@ namespace gui
            }
        };
        onLoadCallback = [&](std::shared_ptr<ContactRecord> contact) {
            if (contact->numbers.size() > 0) {
            if (!contact->numbers.empty()) {
                inputText->setText(contact->numbers[0].number.getEntered());
            }
        };

M module-apps/application-phonebook/windows/PhonebookNewContact.cpp => module-apps/application-phonebook/windows/PhonebookNewContact.cpp +3 -3
@@ 1,4 1,4 @@
// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved.
// Copyright (c) 2017-2023, Mudita Sp. z.o.o. All rights reserved.
// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md

#include "PhonebookNewContact.hpp"


@@ 71,7 71,7 @@ namespace gui
            break;
        }

        !newContactModel->emptyData() ? setSaveButtonVisible(true) : setSaveButtonVisible(false);
        setSaveButtonVisible(!newContactModel->emptyData());
    }

    void PhonebookNewContact::onClose(Window::CloseReason reason)


@@ 121,7 121,7 @@ namespace gui
    {
        auto ret = AppWindow::onInput(inputEvent);

        !newContactModel->emptyData() ? setSaveButtonVisible(true) : setSaveButtonVisible(false);
        setSaveButtonVisible(!newContactModel->emptyData());

        if (inputEvent.isShortRelease(gui::KeyCode::KEY_ENTER) && !newContactModel->emptyData() &&
            newContactModel->verifyData()) {

M pure_changelog.md => pure_changelog.md +2 -1
@@ 20,6 20,8 @@
* Fixed USSD handling crash
* Fixed calls to emergency contact when typed manually
* Fixed message content being deleted when phone mode changed on new message window
* Fixed wrong navigation bar state after exit from custom repeat window
* Fixed OS crash when editing contact by adding country prefix to number

### Added



@@ 108,7 110,6 @@
* Fixed the order in which contacts are displayed in the list.
* Fixed incorrect navigation text in onboarding for timezone and date time.
* Fixed wrong time displayed on password locked screen with 'Quotes' or 'Logo' wallpaper.
* Fixed wrong navigation bar state after exit from custom repeat window


## [1.3.0 2022-08-04]