From 3005b048247b095e9d6a63a654c1e8e2f01ed2e7 Mon Sep 17 00:00:00 2001 From: DariuszSabala Date: Wed, 30 Jun 2021 10:40:20 +0200 Subject: [PATCH] [BH-386] Turned app messages into lib Turned application messages into library, defined dependencies, private and public sources, cleaned include paths, massive cleaned headers --- module-apps/CMakeLists.txt | 3 +- .../widgets/DesktopInputWidget.cpp | 1 - .../ApplicationMessages.cpp | 37 +++--- .../application-messages/CMakeLists.txt | 122 +++++++++++------- .../data/MessagesStyle.hpp | 4 + .../ApplicationMessages.hpp | 7 +- .../application-messages}/Constants.hpp | 0 .../models/SMSTemplateModel.cpp | 11 +- .../models/SMSThreadModel.cpp | 18 +-- .../models/SMSThreadModel.hpp | 13 +- .../models/ThreadsModel.cpp | 17 +-- .../models/ThreadsSearchResultsModel.cpp | 14 +- .../widgets/BaseThreadItem.cpp | 4 +- .../widgets/SMSInputWidget.cpp | 20 +-- .../widgets/SMSOutputWidget.cpp | 10 +- .../widgets/ThreadItem.cpp | 4 +- .../widgets/ThreadItem.hpp | 9 +- .../windows/MessagesMainWindow.cpp | 30 ++--- .../windows/MessagesMainWindow.hpp | 4 +- .../windows/NewMessage.cpp | 19 ++- .../windows/OptionsMessages.cpp | 14 +- .../windows/OptionsMessages.hpp | 7 +- .../windows/SMSTemplatesWindow.cpp | 11 +- .../windows/SMSTemplatesWindow.hpp | 6 +- .../windows/SMSThreadViewWindow.cpp | 21 ++- .../windows/SMSThreadViewWindow.hpp | 6 +- .../windows/SearchResults.cpp | 11 +- .../windows/SearchResults.hpp | 7 +- .../windows/SearchStart.cpp | 4 +- .../windows/ThreadWindowOptions.cpp | 3 +- .../windows/ThreadWindowOptions.hpp | 7 +- products/BellHybrid/BellHybridMain.cpp | 1 - products/PurePhone/CMakeLists.txt | 1 + 33 files changed, 240 insertions(+), 206 deletions(-) rename module-apps/application-messages/{ => include/application-messages}/ApplicationMessages.hpp (99%) rename module-apps/application-messages/{ => include/application-messages}/Constants.hpp (100%) diff --git a/module-apps/CMakeLists.txt b/module-apps/CMakeLists.txt index 545392c4fcd19e33d36bda5c775fc03ba453702b..37cfe805284895fce459c19684219ea841488af6 100644 --- a/module-apps/CMakeLists.txt +++ b/module-apps/CMakeLists.txt @@ -11,6 +11,7 @@ add_library(${PROJECT_NAME} STATIC) add_subdirectory(application-antenna) add_subdirectory(application-bell-main) add_subdirectory(application-calculator) +add_subdirectory(application-messages) add_subdirectory(application-music-player) add_subdirectory(application-phonebook) add_subdirectory(apps-common) @@ -24,7 +25,6 @@ set(APPLICATIONS call notes onboarding - messages calllog special-input meditation @@ -70,6 +70,7 @@ endif() target_link_libraries(${PROJECT_NAME} PRIVATE + application-messages apps-common date::date eventstore diff --git a/module-apps/application-desktop/widgets/DesktopInputWidget.cpp b/module-apps/application-desktop/widgets/DesktopInputWidget.cpp index 2b94af06e3838f7c02edc6f562d16a3800ac297d..bc41ca78373a68160a0137f9baf8977519e03aab 100644 --- a/module-apps/application-desktop/widgets/DesktopInputWidget.cpp +++ b/module-apps/application-desktop/widgets/DesktopInputWidget.cpp @@ -3,7 +3,6 @@ #include "DesktopInputWidget.hpp" #include "AppWindow.hpp" -#include "application-messages/data/MessagesStyle.hpp" #include #include diff --git a/module-apps/application-messages/ApplicationMessages.cpp b/module-apps/application-messages/ApplicationMessages.cpp index d2d295f41a62b6e19ecc14189f125ce5ebc8f9ea..ca3862e5b600010e83420a97366627995899f14e 100644 --- a/module-apps/application-messages/ApplicationMessages.cpp +++ b/module-apps/application-messages/ApplicationMessages.cpp @@ -2,37 +2,34 @@ // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md #include "ApplicationMessages.hpp" +#include "MessagesMainWindow.hpp" +#include "NewMessage.hpp" +#include "OptionsMessages.hpp" +#include "SearchResults.hpp" +#include "SearchStart.hpp" +#include "SMSTemplatesWindow.hpp" +#include "SMSTextToSearch.hpp" +#include "SMSThreadViewWindow.hpp" -#include "DialogMetadata.hpp" -#include "DialogMetadataMessage.hpp" -#include "OptionsWindow.hpp" -#include "application-messages/data/SMSTextToSearch.hpp" -#include "windows/MessagesMainWindow.hpp" -#include "windows/NewMessage.hpp" -#include "windows/OptionsMessages.hpp" -#include "windows/SMSThreadViewWindow.hpp" -#include "windows/SearchStart.hpp" -#include "windows/SMSTemplatesWindow.hpp" -#include "windows/SearchResults.hpp" - -#include #include +#include +#include #include #include -#include -#include -#include -#include - +#include +#include #include #include #include #include #include #include - +#include +#include #include -#include +#include +#include +#include #include #include diff --git a/module-apps/application-messages/CMakeLists.txt b/module-apps/application-messages/CMakeLists.txt index 1b7e15a222473fe4da369708e4d7bc96ad4f6f0f..0a5f98f8b1117c28dbc448c87f2c174316d83f66 100644 --- a/module-apps/application-messages/CMakeLists.txt +++ b/module-apps/application-messages/CMakeLists.txt @@ -1,56 +1,90 @@ -include_directories( ${CMAKE_PROJECT_NAME} +# Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. +# For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md - PUBLIC - "${CMAKE_CURRENT_LIST_DIR}" -) - -include_directories( ${PROJECT_NAME} +add_library(application-messages STATIC) +target_include_directories(application-messages + PRIVATE + $ PUBLIC - "${CMAKE_CURRENT_LIST_DIR}" + $ ) -target_sources( ${PROJECT_NAME} - +target_sources(application-messages PRIVATE - "ApplicationMessages.cpp" - "widgets/ThreadItem.cpp" - "models/SMSTemplateModel.cpp" - "widgets/SMSTemplateItem.cpp" - "widgets/SMSInputWidget.cpp" - "widgets/SMSOutputWidget.cpp" - "widgets/SearchResultsItem.cpp" - "widgets/BaseThreadItem.cpp" - - "models/BaseThreadsRecordModel.cpp" - "models/ThreadsModel.cpp" - "models/ThreadsSearchResultsModel.cpp" - "models/SMSThreadModel.cpp" - - "windows/MessagesMainWindow.cpp" - "windows/SMSThreadViewWindow.cpp" - "windows/NewMessage.cpp" - "windows/ThreadWindowOptions.cpp" - "windows/OptionsMessages.cpp" - "windows/SearchStart.cpp" - "windows/SMSTemplatesWindow.cpp" - "windows/SearchResults.cpp" + ApplicationMessages.cpp + data/MessagesStyle.hpp + data/SMSdata.hpp + data/SMSTextToSearch.cpp + data/SMSTextToSearch.hpp + models/BaseThreadsRecordModel.cpp + models/BaseThreadsRecordModel.hpp + models/SMSTemplateModel.cpp + models/SMSTemplateModel.hpp + models/SMSThreadModel.cpp + models/SMSThreadModel.hpp + models/ThreadsModel.cpp + models/ThreadsModel.hpp + models/ThreadsSearchResultsModel.cpp + models/ThreadsSearchResultsModel.hpp + widgets/BaseThreadItem.cpp + widgets/BaseThreadItem.hpp + widgets/SearchResultsItem.cpp + widgets/SearchResultsItem.hpp + widgets/SMSInputWidget.cpp + widgets/SMSInputWidget.hpp + widgets/SMSOutputWidget.cpp + widgets/SMSOutputWidget.hpp + widgets/SMSTemplateItem.cpp + widgets/SMSTemplateItem.hpp + widgets/ThreadItem.cpp + widgets/ThreadItem.hpp + windows/MessagesMainWindow.cpp + windows/MessagesMainWindow.hpp + windows/NewMessage.cpp + windows/NewMessage.hpp + windows/OptionsMessages.cpp + windows/OptionsMessages.hpp + windows/SearchResults.cpp + windows/SearchResults.hpp + windows/SearchStart.cpp + windows/SearchStart.hpp + windows/SMSTemplatesWindow.cpp + windows/SMSTemplatesWindow.hpp + windows/SMSThreadViewWindow.cpp + windows/SMSThreadViewWindow.hpp + windows/ThreadWindowOptions.cpp + windows/ThreadWindowOptions.hpp + PUBLIC + include/application-messages/ApplicationMessages.hpp + include/application-messages/Constants.hpp +) - "data/SMSTextToSearch.cpp" +option(ENABLE_APP_MESSAGES "Enable application messages" ON) - PUBLIC - "ApplicationMessages.hpp" - "Constants.hpp" - "data/MessagesStyle.hpp" - "models/ThreadsModel.hpp" - "models/SMSThreadModel.hpp" - "widgets/ThreadItem.hpp" - "widgets/SMSInputWidget.hpp" - "widgets/SMSOutputWidget.hpp" +target_compile_definitions(application-messages + INTERFACE + $<$:ENABLE_APP_MESSAGES> ) -target_link_libraries(${PROJECT_NAME} +target_link_libraries(application-messages PRIVATE - service-db clipboard - ) + i18n + log + module-gui + service-appmgr + service-cellular + service-db + time + PUBLIC + apps-common + module-db + module-utils +) diff --git a/module-apps/application-messages/data/MessagesStyle.hpp b/module-apps/application-messages/data/MessagesStyle.hpp index 9d8051fc3c6a86e1d367b1238e20979db954bc59..f22008f070e61a0425d285bfe9dd424476ef9a99 100644 --- a/module-apps/application-messages/data/MessagesStyle.hpp +++ b/module-apps/application-messages/data/MessagesStyle.hpp @@ -3,6 +3,10 @@ #pragma once +#include + +#include + namespace style { namespace messages diff --git a/module-apps/application-messages/ApplicationMessages.hpp b/module-apps/application-messages/include/application-messages/ApplicationMessages.hpp similarity index 99% rename from module-apps/application-messages/ApplicationMessages.hpp rename to module-apps/application-messages/include/application-messages/ApplicationMessages.hpp index 6e172067886d5cc8f9d965f5fc10cc73affe6802..33811ce496702eded2dd450866d4408fd6188597 100644 --- a/module-apps/application-messages/ApplicationMessages.hpp +++ b/module-apps/application-messages/include/application-messages/ApplicationMessages.hpp @@ -3,12 +3,13 @@ #pragma once +#include "Constants.hpp" + #include -#include -#include #include +#include +#include #include -#include "Constants.hpp" namespace gui { diff --git a/module-apps/application-messages/Constants.hpp b/module-apps/application-messages/include/application-messages/Constants.hpp similarity index 100% rename from module-apps/application-messages/Constants.hpp rename to module-apps/application-messages/include/application-messages/Constants.hpp diff --git a/module-apps/application-messages/models/SMSTemplateModel.cpp b/module-apps/application-messages/models/SMSTemplateModel.cpp index f85ad421fcd5bc56364b15809f1d7a0b99e731d1..cd75dcd0feaf50d8a3343f15245e806106307861 100644 --- a/module-apps/application-messages/models/SMSTemplateModel.cpp +++ b/module-apps/application-messages/models/SMSTemplateModel.cpp @@ -1,12 +1,13 @@ -// Copyright (c) 2017-2020, Mudita Sp. z.o.o. All rights reserved. +// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md +#include "ApplicationMessages.hpp" +#include "SMSTemplateItem.hpp" #include "SMSTemplateModel.hpp" -#include "ListView.hpp" -#include "application-messages/widgets/SMSTemplateItem.hpp" -#include "application-messages/ApplicationMessages.hpp" -#include + +#include #include +#include SMSTemplateModel::SMSTemplateModel(app::Application *app) : DatabaseModel(app), app::AsyncCallbackReceiver{app} {} diff --git a/module-apps/application-messages/models/SMSThreadModel.cpp b/module-apps/application-messages/models/SMSThreadModel.cpp index 4761df0118aa41023565fbb87b822288c2012e06..7add92aa2144c879bf75f97afb8d813106636502 100644 --- a/module-apps/application-messages/models/SMSThreadModel.cpp +++ b/module-apps/application-messages/models/SMSThreadModel.cpp @@ -1,16 +1,16 @@ -// Copyright (c) 2017-2020, Mudita Sp. z.o.o. All rights reserved. +// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md -#include -#include +#include "ApplicationMessages.hpp" +#include "MessagesStyle.hpp" +#include "SMSOutputWidget.hpp" +#include "SMSThreadModel.hpp" + +#include #include #include - -#include -#include -#include "application-messages/data/MessagesStyle.hpp" -#include "SMSThreadModel.hpp" -#include "ListView.hpp" +#include +#include SMSThreadModel::SMSThreadModel(app::Application *app) : DatabaseModel(app), app::AsyncCallbackReceiver{app} { diff --git a/module-apps/application-messages/models/SMSThreadModel.hpp b/module-apps/application-messages/models/SMSThreadModel.hpp index 9c1abf9757300af7c3ee450e886a8c08cc80f615..14847ae7422588680206d111600e141d1f7a011f 100644 --- a/module-apps/application-messages/models/SMSThreadModel.hpp +++ b/module-apps/application-messages/models/SMSThreadModel.hpp @@ -1,13 +1,14 @@ -// Copyright (c) 2017-2020, Mudita Sp. z.o.o. All rights reserved. +// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md #pragma once -#include "DatabaseModel.hpp" -#include "Application.hpp" -#include "ListItemProvider.hpp" -#include "Interface/SMSRecord.hpp" -#include +#include "SMSInputWidget.hpp" + +#include +#include +#include +#include class SMSThreadModel : public app::DatabaseModel, public gui::ListItemProvider, diff --git a/module-apps/application-messages/models/ThreadsModel.cpp b/module-apps/application-messages/models/ThreadsModel.cpp index 358bb85d3ee0107acb855035fbcbb98f57d9ad04..446c1fbcb1dca3d5afe255760c86ae370e0ed76d 100644 --- a/module-apps/application-messages/models/ThreadsModel.cpp +++ b/module-apps/application-messages/models/ThreadsModel.cpp @@ -1,18 +1,19 @@ // Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md +#include "MessagesStyle.hpp" +#include "SMSdata.hpp" +#include "ThreadItem.hpp" #include "ThreadsModel.hpp" -#include "InputEvent.hpp" -#include "OptionWindow.hpp" -#include "OptionsWindow.hpp" -#include "ListView.hpp" -#include "application-messages/data/SMSdata.hpp" -#include "application-messages/data/MessagesStyle.hpp" -#include "application-messages/widgets/ThreadItem.hpp" -#include "application-messages/windows/ThreadWindowOptions.hpp" +#include "ThreadWindowOptions.hpp" + +#include +#include #include #include #include +#include +#include #include ThreadsModel::ThreadsModel(app::Application *app) : BaseThreadsRecordModel(app), app::AsyncCallbackReceiver{app} diff --git a/module-apps/application-messages/models/ThreadsSearchResultsModel.cpp b/module-apps/application-messages/models/ThreadsSearchResultsModel.cpp index b99fff166708215359ce8956b58022e29745b7a5..726ef018acba885bf65ff4b1284880f181fd586b 100644 --- a/module-apps/application-messages/models/ThreadsSearchResultsModel.cpp +++ b/module-apps/application-messages/models/ThreadsSearchResultsModel.cpp @@ -1,15 +1,15 @@ -// Copyright (c) 2017-2020, Mudita Sp. z.o.o. All rights reserved. +// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. // For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md +#include "ApplicationMessages.hpp" +#include "MessagesStyle.hpp" +#include "SearchResultsItem.hpp" #include "ThreadsSearchResultsModel.hpp" -#include "ListView.hpp" -#include