From 3b67389034e33bc10f8f6ebcbbd93d4495476f88 Mon Sep 17 00:00:00 2001 From: Jakub Pyszczak Date: Thu, 15 Jul 2021 13:52:25 +0200 Subject: [PATCH] [EGD-7162] Removed sensitive data from settings app During validation tests of EGD-6962 found sensitive data being logged in settings app. This PR deletes all of those. --- module-apps/application-settings/ApplicationSettings.cpp | 2 +- .../application-settings/windows/bluetooth/AddDeviceWindow.cpp | 1 - .../application-settings/windows/bluetooth/AllDevicesWindow.cpp | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/module-apps/application-settings/ApplicationSettings.cpp b/module-apps/application-settings/ApplicationSettings.cpp index 806383f9914b0078d47e8a6561c575653dcac910..0d80171833d4e4c0770cfafc9788ba7658d85db2 100644 --- a/module-apps/application-settings/ApplicationSettings.cpp +++ b/module-apps/application-settings/ApplicationSettings.cpp @@ -97,7 +97,7 @@ namespace app { CellularServiceAPI::SubscribeForOwnNumber(this, [&](const std::string &number) { selectedSimNumber = number; - LOG_DEBUG("Sim number changed: %s", selectedSimNumber.c_str()); + LOG_DEBUG("Sim number changed"); }); if ((Store::GSM::SIM::SIM1 == selectedSim || Store::GSM::SIM::SIM2 == selectedSim) && Store::GSM::get()->sim == selectedSim) { diff --git a/module-apps/application-settings/windows/bluetooth/AddDeviceWindow.cpp b/module-apps/application-settings/windows/bluetooth/AddDeviceWindow.cpp index d7a95914ea0cab92f1ac32ea221f28adfa1ce487..79b7186d4a9a2c355b739ca5710955b01a5b4578 100644 --- a/module-apps/application-settings/windows/bluetooth/AddDeviceWindow.cpp +++ b/module-apps/application-settings/windows/bluetooth/AddDeviceWindow.cpp @@ -43,7 +43,6 @@ namespace gui optionsList.emplace_back(std::make_unique( device.name, [=](gui::Item & /*unused*/) { - LOG_DEBUG("Device: %s", device.name.c_str()); auto pairingDeviceData = std::make_unique(device); application->switchWindow(gui::window::name::all_devices, std::move(pairingDeviceData)); bluetoothSettingsModel->requestDevicePair(bd_addr_to_str(device.address)); diff --git a/module-apps/application-settings/windows/bluetooth/AllDevicesWindow.cpp b/module-apps/application-settings/windows/bluetooth/AllDevicesWindow.cpp index 733c7a4dc7faa3e2c6a001c76be2a3f7bc2f2d30..143c6a2006287741d667bdc078d735c99072be3c 100644 --- a/module-apps/application-settings/windows/bluetooth/AllDevicesWindow.cpp +++ b/module-apps/application-settings/windows/bluetooth/AllDevicesWindow.cpp @@ -123,7 +123,6 @@ namespace gui optionsList.emplace_back(std::make_unique( device.name, [=](gui::Item & /*item*/) { - LOG_DEBUG("Device: %s", device.name.c_str()); return handleDeviceAction(newDevice); }, [=](gui::Item &item) {