From 48a1c00a31b0b2bd63384a012246b825581194e7 Mon Sep 17 00:00:00 2001 From: Adam Date: Tue, 24 Nov 2020 10:31:08 +0100 Subject: [PATCH] CODEOWNERS file syntax fixed (#1072) Github CODEOWNERS file syntax fixed --- .github/CODEOWNERS | 86 ++++++++++++++++++++++++++-------------------- 1 file changed, 48 insertions(+), 38 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 11fd503c438d329b41bf577e8630144780f99a52..a13957506d65e493bb65e0243bdc5d51b39a20ee 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,55 +1,65 @@ -# all devs are codeovners +# Please mind that: +# 1. in CODEOWNERS file there is no `/**` syntax but we end catalog without `/` which means whole catalog and subdirs +# example `dir @owner` means whole dir and it's subdirectory +# 2. in CODEOWNERS file ending catalog with `/` means "cutoff +# example `dir @owner` means whole only dir **without subdirs** +# 3. starting dir from `/` means `from root dir` whereas without means `all such catalogs` (like we would do with extglob `**/` +# 4. Sub groups are marked from organization, not group so we don't have `@mudita/os/embedded-abs` but `@mudita/embedded-abs` +# +# CODEOWNERS for teams have some issues: https://github.community/t/codeowners-works-with-users-but-not-teams/733 + +\.github @pholat @rwicik @alekrudnik + +# all `os` devs are codeovners * @mudita/os -#docments +#documents *.md @wojtekidd -/doc/** @wojtekidd +/doc @wojtekidd #modules -/module-audio/** @hubert-chrzaniuk @jimmorrisson @alekrudnik -/module-bluetooth/** @SP2FET -/module-bsp/** @grzyw-o-mat @SzMrMdt -/module-cellular/** @kkleczkowski @alekrudnik -/module-db/** @mudita/os/embedded-abs @pholat @PrzeBrudny -/module-gui/** @PrzeBrudny @pholat @mozdzyk -/module-utils/** @alekrudnik @mpsm @piotr-tanski +/module-audio @hubert-chrzaniuk @jimmorrisson @alekrudnik +/module-bluetooth @SP2FET +/module-bsp @grzyw-o-mat @SzMrMdt +/module-cellular @kkleczkowski @alekrudnik +/module-db @mudita/embedded-abs @pholat @PrzeBrudny +/module-gui @PrzeBrudny @pholat @mozdzyk +/module-utils @alekrudnik @mpsm @piotr-tanski /module-utils/PhoneNumber.* @mpsm -/module-vfs/** @lucckb @alekrudnik @rkubiak01 @SzMrMdt -/module_services/** @alekrudnik +/module-vfs @lucckb @alekrudnik @rkubiak01 @SzMrMdt +/module_services @alekrudnik #system -/module-bsp/board/rt1051/bsp/audio/** @mpsm @alekrudnik -/module-os/** @mpsm -/module-sys/** @mpsm @alekrudnik -/module-sys/Service/** @pholat +/module-bsp/board/rt1051/bsp/audio @mpsm @alekrudnik +/module-os @mpsm +/module-sys @mpsm @alekrudnik +/module-sys/Service @pholat #services -/module_services/service-antenna/** @kkleczkowski -/module-services/service-appmgr/** @pholat @piotr-tanski -/module_services/service-audio/** @hubert-chrzaniuk @jimmorrisson -/module_services/service-cellular/** @kkleczkowski -/module-services/service-db/** @mudita/os/embedded-abs @PrzeBrudny -/module-services/service-desktop/** @SP2FET @rkubiak01 -/module_services/service-file-indexer/** @lucckb +/module_services/service-antenna @kkleczkowski +/module-services/service-appmgr @pholat @piotr-tanski +/module_services/service-audio @hubert-chrzaniuk @jimmorrisson +/module_services/service-cellular @kkleczkowski +/module-services/service-db @mudita/embedded-abs @PrzeBrudny +/module-services/service-desktop @SP2FET @rkubiak01 +/module_services/service-file-indexer @lucckb #apps -/module-apps/** @piotr-tanski @pholat @PrzeBrudny -/module-apps/application-calendar/** @PrzeBrudny @pholat @alekrudnik -/module-apps/application-call/** @alekrudnik -/module-apps/application-calllog/** @mudita/os/embedded-abs -/module-apps/application-messages/** @PrzeBrudny -/module-apps/application-music-player/** @alekrudnik -/module-apps/application-phonebook/** @mudita/os/embedded-abs @PrzeBrudny -/module-apps/application-settings-new/** @mudita/os/embedded-abs -/module-apps/application-settings/** @mudita/os/embedded-abs +/module-apps @piotr-tanski @pholat @PrzeBrudny +/module-apps/application-calendar @PrzeBrudny @pholat @alekrudnik +/module-apps/application-call @alekrudnik +/module-apps/application-calllog @mudita/embedded-abs +/module-apps/application-messages @PrzeBrudny +/module-apps/application-music-player @alekrudnik +/module-apps/application-phonebook @mudita/embedded-abs @PrzeBrudny +/module-apps/application-settings-new @mudita/embedded-abs +/module-apps/application-settings @mudita/embedded-abs #build system *.cmake @rwicik @mpsm *.sh @pholat @rwicik @lucckb -.github/** @rwicik -.gitmodules @mpsm @rwicik -/board/rt1051/ldscripts/** @mpsm -/config/** @rwicik @rkubiak01 -/docker/** @rwicik +\.gitmodules @mpsm @rwicik +/board/rt1051/ldscripts @mpsm +/config @rwicik @rkubiak01 +/docker @rwicik CMakeLists.txt @rwicik @mpsm -