From 5ce8bbc7d8cdd548eaa8071afdde5a88243cca05 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Jo=C5=84ski?= Date: Wed, 25 May 2022 11:23:50 +0200 Subject: [PATCH] [BH-1494] Frontlight arrows show fix - remove regressions Previous solution caused some regressions along the system This approach solves the bug differently, avoiding those regressions --- .../apps-common/widgets/spinners/StringOutputSpinner.hpp | 1 - .../common/include/common/widgets/list_items/details.hpp | 6 +++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/module-apps/apps-common/widgets/spinners/StringOutputSpinner.hpp b/module-apps/apps-common/widgets/spinners/StringOutputSpinner.hpp index 5b151187015f121a97acf8bd8bf595a23b1ea5bd..bb357ed9c8140b429b7109e39ee6bc21beab7e8a 100644 --- a/module-apps/apps-common/widgets/spinners/StringOutputSpinner.hpp +++ b/module-apps/apps-common/widgets/spinners/StringOutputSpinner.hpp @@ -177,7 +177,6 @@ namespace gui { container.set(value); update(); - invoke(); } template diff --git a/products/BellHybrid/apps/common/include/common/widgets/list_items/details.hpp b/products/BellHybrid/apps/common/include/common/widgets/list_items/details.hpp index a8c854aba2d735614104b4d48e9a71dba061ce54..ffe20cde8c29c154d7c7c520b24a48066f259eee 100644 --- a/products/BellHybrid/apps/common/include/common/widgets/list_items/details.hpp +++ b/products/BellHybrid/apps/common/include/common/widgets/list_items/details.hpp @@ -28,6 +28,7 @@ namespace app::list_items void set_value(const value_type &value) { spinner->set_value(value); + control_visibility(); } void set_range(const typename spinner_type::range &range) @@ -75,7 +76,10 @@ namespace app::list_items }; getValue = [this]() { this->model.setValue(this->spinner->value()); }; - setValue = [this]() { this->spinner->set_value(this->model.getValue()); }; + setValue = [this]() { + this->spinner->set_value(this->model.getValue()); + control_visibility(); + }; inputCallback = [this, &bottomDescription](Item &, const gui::InputEvent &event) { return OnInputCallback(event);