7 files changed, 17 insertions(+), 27 deletions(-)

M module-bsp/CMakeLists.txt
M module-bsp/board/rt1051/CMakeLists.txt
M module-bsp/board/rt1051/bellpx/bsp/audio/AW8898driver.cpp
M module-bsp/board/rt1051/bellpx/bsp/switches/switches.cpp
M module-bsp/board/rt1051/bsp/rtc/rtc.cpp
M module-bsp/board/rt1051/puretx/bsp/battery_charger/battery_charger.cpp
M module-bsp/devices/power/CW2015.cpp

@@ 38,8 38,6 @@ target_compile_options(${PROJECT_NAME}
     -Wno-missing-field-initializers
     -Wno-unused-function
     -Wno-switch
-    -Wno-implicit-fallthrough
-    -Wno-unused-variable
 
     # C only flags
     $<$<COMPILE_LANGUAGE:C>:-Wno-old-style-declaration>

@@ 67,8 67,6 @@ target_include_directories(module-bsp
 
 set_source_files_properties(
 	eMMC/fsl_mmc.c PROPERTIES COMPILE_FLAGS -Wno-unused-function
-	common/i2c.c PROPERTIES COMPILE_FLAGS -Wno-unused-function
-    bsp/rtc/rtc.cpp PROPERTIES COMPILE_FLAGS "-Wno-unused-value -Wno-error=unused-value"
 )
 
 target_compile_definitions(module-bsp PUBLIC USB_STACK_FREERTOS)

@@ 518,7 518,6 @@ namespace bsp::audio::AW8898
 
     void HAL_Delay(std::uint32_t count)
     {
-        extern std::uint32_t SystemCoreClock;
         vTaskDelay(pdMS_TO_TICKS(count));
     }
 

@@ 159,8 159,7 @@ namespace bsp::bell_switches
 
     void debounceTimerCallback(TimerHandle_t timerHandle)
     {
-        auto timerState                     = static_cast<DebounceTimerState *>(pvTimerGetTimerID(timerHandle));
-        BaseType_t xHigherPriorityTaskWoken = pdFALSE;
+        auto timerState = static_cast<DebounceTimerState *>(pvTimerGetTimerID(timerHandle));
         xTimerStop(timerState->timer, 0);
 
         auto currentState = timerState->gpio->ReadPin(static_cast<uint32_t>(timerState->pin)) ? KeyEvents::Released


@@ 191,8 190,7 @@ namespace bsp::bell_switches
 
     void debounceTimerCenterClickCallback(TimerHandle_t timerHandle)
     {
-        auto timerState                     = static_cast<DebounceTimerState *>(pvTimerGetTimerID(timerHandle));
-        BaseType_t xHigherPriorityTaskWoken = pdFALSE;
+        auto timerState = static_cast<DebounceTimerState *>(pvTimerGetTimerID(timerHandle));
         xTimerStop(timerState->timer, 0);
 
         if (qHandleIrq != nullptr) {


@@ 317,7 315,6 @@ namespace bsp::bell_switches
             return;
         }
         DebounceTimerState &debounceTimerState = debounceTimers.at(timerId);
-        auto temp                              = &debounceTimerState;
         debounceTimerState.gpio->DisableInterrupt(1U << static_cast<uint32_t>(debounceTimerState.pin));
         debounceTimerState.lastState = debounceTimerState.gpio->ReadPin(static_cast<uint32_t>(debounceTimerState.pin))
                                            ? KeyEvents::Released


@@ 375,7 372,6 @@ namespace bsp::bell_switches
         gpio_sw->DisableInterrupt(1 << static_cast<uint32_t>(BoardDefinitions::BELL_SWITCHES_LATCH));
     }
 
-
     std::vector<KeyEvent> getKeyEvents(NotificationSource notification)
     {
         std::vector<KeyEvent> out;

@@ 238,7 238,8 @@ namespace bsp::rtc
     {
         std::uint32_t secondsToMinute = 60 - (timestamp % 60);
 
-        struct tm date;
+        struct tm date
+        {};
         getCurrentDateTime(&date);
 
         return setAlarmInSecondsFromNow(secondsToMinute);

@@ 544,7 544,7 @@ namespace bsp::battery_charger
 
         // Short time to synchronize after configuration
         vTaskDelay(pdMS_TO_TICKS(100));
-        StateOfCharge level = getBatteryLevel();
+        getBatteryLevel();
 
         clearAllChargerIRQs();
         clearFuelGuageIRQ(static_cast<std::uint16_t>(batteryINTBSource::all));

@@ 50,7 50,6 @@ namespace bsp::devices::power
         constexpr auto micro_to_milli_ratio    = 1000;
         constexpr auto adc_conversion_constant = 305;
 
-        uint8_t volt_h, volt_l;
         uint32_t ADMin = 0, ADMax = 0, ADResult = 0;
 
         /// Filter data using median


@@ 278,19 277,18 @@ namespace bsp::devices::power
         BATTINFO profile{};
         RetCodes ret_code{RetCodes::Ok};
 
-        const auto result = std::all_of(
-            profile.cbegin(), profile.cend(), [this, ret_code, reg = BATTINFO::ADDRESS](const auto &e) mutable {
-                const auto result = read(reg++);
-                if (not result) {
-                    ret_code = RetCodes::CommunicationError;
-                    return false;
-                }
-                if (*result != e) {
-                    ret_code = RetCodes::ProfileInvalid;
-                    return false;
-                }
-                return true;
-            });
+        std::all_of(profile.cbegin(), profile.cend(), [this, ret_code, reg = BATTINFO::ADDRESS](const auto &e) mutable {
+            const auto result = read(reg++);
+            if (not result) {
+                ret_code = RetCodes::CommunicationError;
+                return false;
+            }
+            if (*result != e) {
+                ret_code = RetCodes::ProfileInvalid;
+                return false;
+            }
+            return true;
+        });
 
         return ret_code;
     }