From 82e720718b3d10ff9e7f0b389284b6253b25db74 Mon Sep 17 00:00:00 2001 From: Tigran Soghbatyan Date: Thu, 4 Nov 2021 11:15:01 +0100 Subject: [PATCH] [BH-1088] Adjust meditation app end view Remove text from meditation end view Make the icon centered --- .../ApplicationBellMeditationTimer.cpp | 10 +++--- .../CMakeLists.txt | 1 - .../presenter/MeditationProgressPresenter.cpp | 4 ++- .../windows/SessionEndWindow.cpp | 32 ------------------- .../windows/SessionEndWindow.hpp | 26 --------------- 5 files changed, 8 insertions(+), 65 deletions(-) delete mode 100644 products/BellHybrid/apps/application-bell-meditation-timer/windows/SessionEndWindow.cpp delete mode 100644 products/BellHybrid/apps/application-bell-meditation-timer/windows/SessionEndWindow.hpp diff --git a/products/BellHybrid/apps/application-bell-meditation-timer/ApplicationBellMeditationTimer.cpp b/products/BellHybrid/apps/application-bell-meditation-timer/ApplicationBellMeditationTimer.cpp index 48217a364f7e2c91ca8022ca5490af9554169475..aabcdec9fd6203a850911822fa6869e7ad42bbac 100644 --- a/products/BellHybrid/apps/application-bell-meditation-timer/ApplicationBellMeditationTimer.cpp +++ b/products/BellHybrid/apps/application-bell-meditation-timer/ApplicationBellMeditationTimer.cpp @@ -6,10 +6,10 @@ #include "windows/MeditationRunningWindow.hpp" #include "windows/MeditationTimerWindow.hpp" #include "windows/ReadyGoingWindow.hpp" -#include "windows/SessionEndWindow.hpp" #include "windows/SessionPausedWindow.hpp" #include +#include namespace app { @@ -60,10 +60,10 @@ namespace app windowsFactory.attach(gui::name::window::sessionPaused, [](ApplicationCommon *app, const std::string &name) { return std::make_unique(app); }); - windowsFactory.attach(gui::name::window::sessionEnded, [](ApplicationCommon *app, const std::string &name) { - auto presenter = std::make_unique(app); - return std::make_unique(app, std::move(presenter)); - }); + windowsFactory.attach(gui::window::bell_finished::defaultName, + [](ApplicationCommon *app, const std::string &name) { + return std::make_unique(app); + }); attachPopups({gui::popup::ID::AlarmActivated, gui::popup::ID::AlarmDeactivated, diff --git a/products/BellHybrid/apps/application-bell-meditation-timer/CMakeLists.txt b/products/BellHybrid/apps/application-bell-meditation-timer/CMakeLists.txt index 47442cd0e70424dee4f417725477c1c3d80dfbfc..9604ad84566e271bf8f469ff5338ff89a324cc81 100644 --- a/products/BellHybrid/apps/application-bell-meditation-timer/CMakeLists.txt +++ b/products/BellHybrid/apps/application-bell-meditation-timer/CMakeLists.txt @@ -28,7 +28,6 @@ target_sources(application-bell-meditation-timer windows/MeditationRunningWindow.cpp windows/MeditationTimerWindow.cpp windows/ReadyGoingWindow.cpp - windows/SessionEndWindow.cpp windows/SessionPausedWindow.cpp PUBLIC include/application-bell-meditation-timer/ApplicationBellMeditationTimer.hpp diff --git a/products/BellHybrid/apps/application-bell-meditation-timer/presenter/MeditationProgressPresenter.cpp b/products/BellHybrid/apps/application-bell-meditation-timer/presenter/MeditationProgressPresenter.cpp index d9c829d47ead744f890c3d4d76891cc12d09f77a..f707c726005e7bf1933db4a391cc9f719acf3fb4 100644 --- a/products/BellHybrid/apps/application-bell-meditation-timer/presenter/MeditationProgressPresenter.cpp +++ b/products/BellHybrid/apps/application-bell-meditation-timer/presenter/MeditationProgressPresenter.cpp @@ -6,6 +6,7 @@ #include "MeditationProgressPresenter.hpp" #include +#include #include #include @@ -75,7 +76,8 @@ namespace app::meditation void MeditationProgressPresenter::finish() { timer->stop(); - app->switchWindow(gui::name::window::sessionEnded); + app->switchWindow(gui::window::bell_finished::defaultName, + gui::BellFinishedWindowData::Factory::create("big_namaste_W_G", "", "", true)); } void MeditationProgressPresenter::onProgressFinished() diff --git a/products/BellHybrid/apps/application-bell-meditation-timer/windows/SessionEndWindow.cpp b/products/BellHybrid/apps/application-bell-meditation-timer/windows/SessionEndWindow.cpp deleted file mode 100644 index a58f1f6efc8ba0bcef25ed2927a389e1447d183d..0000000000000000000000000000000000000000 --- a/products/BellHybrid/apps/application-bell-meditation-timer/windows/SessionEndWindow.cpp +++ /dev/null @@ -1,32 +0,0 @@ -// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. -// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md - -#include "ApplicationBellMeditationTimer.hpp" -#include "SessionEndWindow.hpp" - -namespace gui -{ - SessionEndWindow::SessionEndWindow( - app::ApplicationCommon *app, - std::shared_ptr winPresenter) - : BellFinishedWindow(app, gui::name::window::sessionEnded), presenter{std::move(winPresenter)} - { - timerCallback = [this](Item &, sys::Timer &) { - presenter->activate(); - return true; - }; - } - - bool SessionEndWindow::onInput(const InputEvent &inputEvent) - { - return true; - } - - void SessionEndWindow::onBeforeShow(ShowMode mode, SwitchData *data) - { - BellFinishedWindow::onBeforeShow(mode, data); - - icon->image->set("big_namaste", ImageTypeSpecifier::W_G); - icon->text->setRichText(utils::translate("app_bell_meditation_thank_you_for_session")); - } -} // namespace gui diff --git a/products/BellHybrid/apps/application-bell-meditation-timer/windows/SessionEndWindow.hpp b/products/BellHybrid/apps/application-bell-meditation-timer/windows/SessionEndWindow.hpp deleted file mode 100644 index 532850144ba2f2c618d78fc275ea4235484146af..0000000000000000000000000000000000000000 --- a/products/BellHybrid/apps/application-bell-meditation-timer/windows/SessionEndWindow.hpp +++ /dev/null @@ -1,26 +0,0 @@ -// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved. -// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md - -#pragma once - -#include "SessionEndedPresenter.hpp" - -#include -#include - -namespace gui -{ - class SessionEndWindow : public BellFinishedWindow - { - private: - std::shared_ptr presenter; - - public: - SessionEndWindow(app::ApplicationCommon *app, - std::shared_ptr winPresenter); - - // virtual methods - bool onInput(const InputEvent &inputEvent) override; - void onBeforeShow(ShowMode mode, SwitchData *data) override; - }; -} // namespace gui