~aleteoryx/muditaos: [BH-2081] Fix crash for MP3s with missing Xing frame

b9a106b11c16baa85bbb9f0e25855ace658aad7b — Lefucjusz 1 year, 1 month ago a6e1e54

[BH-2081] Fix crash for MP3s with missing Xing frame

Fix of the issue that playing large MP3
files with missing Xing frame would
result in crash due to minimp3
trying to compute metadata by analyzing
the entire file and running out of
heap memory.

patch browse .tar.gz

1 files changed, 3 insertions(+), 2 deletions(-)

M module-audio/Audio/decoder/DecoderMP3.cpp

M module-audio/Audio/decoder/DecoderMP3.cpp => module-audio/Audio/decoder/DecoderMP3.cpp +3 -2

@@ 23,8 23,9 @@ namespace audio
         io->seek_data = this;
         dec->io       = io.get();
 
-        if (mp3dec_ex_open_cb(dec.get(), dec->io, MP3D_SEEK_TO_SAMPLE)) {
-            LOG_ERROR("Failed to open minimp3");
+        const auto decoderStatus = mp3dec_ex_open_cb(dec.get(), dec->io, MP3D_SEEK_TO_SAMPLE | MP3D_DO_NOT_SCAN);
+        if (decoderStatus != 0) {
+            LOG_ERROR("Failed to open minimp3, error: %d", decoderStatus);
             return;
         }