From cf1ec5d1029ee40b1f14a816525c5eb99d67e0b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcin=20Zieli=C5=84ski?= Date: Fri, 14 Oct 2022 16:49:54 +0200 Subject: [PATCH] [MOS-769] Make a destructor virtual Make Make gui::popup::Filter's destructor virtual because it has a virtual method. Additionally, added a documenting comment. --- module-apps/apps-common/WindowsPopupFilter.hpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/module-apps/apps-common/WindowsPopupFilter.hpp b/module-apps/apps-common/WindowsPopupFilter.hpp index 74b3feaaa159c65a18ea631e90fb639cea1ffb72..10eb0f3cc4bf3a7e2ffae34284d7f502a424265d 100644 --- a/module-apps/apps-common/WindowsPopupFilter.hpp +++ b/module-apps/apps-common/WindowsPopupFilter.hpp @@ -22,9 +22,12 @@ namespace gui::popup { private: std::list> appDependentFilter; + /// non-owning pointer to existing stack - @see attachWindowsStack() app::WindowsStack *stack = nullptr; public: + virtual ~Filter() = default; + void attachWindowsStack(app::WindowsStack *stack); void addAppDependentFilter(std::function f); virtual bool isPermitted(const gui::PopupRequestParams ¶ms) const;