From d0ac5f989ea9e718387533fdc4ddcf72188e41af Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pawe=C5=82=20Jo=C5=84ski?= <pawel.jonski@mudita.com>
Date: Fri, 14 Jan 2022 15:14:02 +0100
Subject: [PATCH] [BH-1193] Snooze length UI sync

Snooze length UI sync
Rounding up the snooze length
---
 .../presenters/HomeScreenPresenter.hpp        |  3 +-
 .../presenters/StateController.cpp            |  8 +++---
 .../widgets/SnoozeTimer.cpp                   |  8 ++++++
 .../widgets/SnoozeTimer.hpp                   |  1 +
 .../windows/BellHomeScreenWindow.cpp          | 11 +++++++-
 .../common/models/AbstractAlarmModel.hpp      |  3 +-
 .../include/common/models/AlarmModel.hpp      |  5 +++-
 .../BellHybrid/apps/common/src/AlarmModel.cpp | 28 +++++++++++++------
 8 files changed, 50 insertions(+), 17 deletions(-)

diff --git a/products/BellHybrid/apps/application-bell-main/presenters/HomeScreenPresenter.hpp b/products/BellHybrid/apps/application-bell-main/presenters/HomeScreenPresenter.hpp
index fb60bbd95f9f75d19ec68b0dcc667be22fe14f81..28473371e1869d79f087a6d538f1feeadc5cd1c6 100644
--- a/products/BellHybrid/apps/application-bell-main/presenters/HomeScreenPresenter.hpp
+++ b/products/BellHybrid/apps/application-bell-main/presenters/HomeScreenPresenter.hpp
@@ -45,7 +45,8 @@ namespace app::home_screen
         Empty,
         AlarmIcon,
         AlarmIconAndTime,
-        SnoozeCountdown
+        SnoozeIcon,
+        SnoozeIconAndTime
     };
 
     class AbstractView
diff --git a/products/BellHybrid/apps/application-bell-main/presenters/StateController.cpp b/products/BellHybrid/apps/application-bell-main/presenters/StateController.cpp
index 2282967927726bc29787186cb4dc307fe73fdb0e..1aaffbe1fd89c2454b5e035fb81817887d3564b1 100644
--- a/products/BellHybrid/apps/application-bell-main/presenters/StateController.cpp
+++ b/products/BellHybrid/apps/application-bell-main/presenters/StateController.cpp
@@ -14,6 +14,7 @@
 #include <boost/sml.hpp>
 #include <time/time_conversion.hpp>
 
+#include <chrono>
 #include <random>
 
 /// Uncomment to print state machine debug logs
@@ -274,8 +275,7 @@ namespace app::home_screen
             auto entry = [](AbstractView &view, AbstractAlarmModel &alarmModel, AbstractPresenter &presenter) {
                 presenter.spawnTimer();
                 alarmModel.snooze();
-                view.setHeaderViewMode(HeaderViewMode::SnoozeCountdown);
-                view.setSnoozeTime(alarmModel.getTimeOfNextSnooze());
+                view.setHeaderViewMode(HeaderViewMode::SnoozeIcon);
                 const auto bottomDescription =
                     utils::time::getBottomDescription(alarmModel.getSnoozeDuration().count());
                 view.setBottomDescription(bottomDescription);
@@ -289,9 +289,9 @@ namespace app::home_screen
                             AbstractAlarmModel &alarmModel,
                             AbstractTemperatureModel &temperatureModel,
                             AbstractBatteryModel &batteryModel) {
-                view.setHeaderViewMode(HeaderViewMode::SnoozeCountdown);
+                view.setHeaderViewMode(HeaderViewMode::SnoozeIconAndTime);
+                view.setSnoozeTime(Clock::to_time_t(alarmModel.getTimeOfNextSnooze()));
                 view.setTemperature(temperatureModel.getTemperature());
-                view.setSnoozeTime(alarmModel.getTimeOfNextSnooze());
                 view.setBatteryLevelState(batteryModel.getLevelState());
             };
             auto exit = [](AbstractPresenter &presenter) { presenter.stopSnoozeTimer(); };
diff --git a/products/BellHybrid/apps/application-bell-main/widgets/SnoozeTimer.cpp b/products/BellHybrid/apps/application-bell-main/widgets/SnoozeTimer.cpp
index 6d0c074002df7da28ffb019c7394d8aa97e07269..d4d794606d224bdaba3703ac80a2480cefcd62e4 100644
--- a/products/BellHybrid/apps/application-bell-main/widgets/SnoozeTimer.cpp
+++ b/products/BellHybrid/apps/application-bell-main/widgets/SnoozeTimer.cpp
@@ -25,6 +25,7 @@ namespace gui
         timeSpinner->setAlignment(Alignment(Alignment::Horizontal::Center, Alignment::Vertical::Center));
         timeSpinner->setMargins(Margins(0, 0, 10U, 0));
         timeSpinner->setEdges(RectangleEdge::None);
+        timeSpinner->setFocusItem(nullptr);
 
         resizeItems();
     }
@@ -50,4 +51,11 @@ namespace gui
         timeSpinner->setTimeFormat(fmt);
     }
 
+    auto SnoozeTimer::setTimerVisible(bool visible) noexcept -> void
+    {
+        timeSpinner->setVisible(visible);
+        timeSpinner->setFocusItem(nullptr);
+        timeSpinner->informContentChanged();
+    }
+
 } /* namespace gui */
diff --git a/products/BellHybrid/apps/application-bell-main/widgets/SnoozeTimer.hpp b/products/BellHybrid/apps/application-bell-main/widgets/SnoozeTimer.hpp
index 9bec0781905b27708c83329821e5e7f65de4a470..822cac63d0775c0a350258079565cd063e46bf44 100644
--- a/products/BellHybrid/apps/application-bell-main/widgets/SnoozeTimer.hpp
+++ b/products/BellHybrid/apps/application-bell-main/widgets/SnoozeTimer.hpp
@@ -34,6 +34,7 @@ namespace gui
         auto setTime(std::uint8_t mins, std::uint8_t secs) noexcept -> void;
         auto setTime(std::time_t time) noexcept -> void;
         auto setTimeFormat(utils::time::Locale::TimeFormat fmt) noexcept -> void;
+        auto setTimerVisible(bool visible) noexcept -> void;
 
       private:
         TimeSetFmtSpinner *timeSpinner = nullptr;
diff --git a/products/BellHybrid/apps/application-bell-main/windows/BellHomeScreenWindow.cpp b/products/BellHybrid/apps/application-bell-main/windows/BellHomeScreenWindow.cpp
index d78122ee6199131d67c542900c6ae825d28202a2..7f36832d0f57401fe955d11959640f0c208f2f6b 100644
--- a/products/BellHybrid/apps/application-bell-main/windows/BellHomeScreenWindow.cpp
+++ b/products/BellHybrid/apps/application-bell-main/windows/BellHomeScreenWindow.cpp
@@ -104,6 +104,7 @@ namespace gui
         snoozeTimer = new SnoozeTimer(body->firstBox);
         snoozeTimer->setMinimumSize(style::bell_base_layout::outer_layouts_w, style::bell_base_layout::outer_layouts_h);
         snoozeTimer->setVisible(false);
+        snoozeTimer->setAlignment(Alignment(Alignment::Horizontal::Center, Alignment::Vertical::Center));
 
         time = new TimeSetFmtSpinner(body->centerBox);
         time->setMaximumSize(style::bell_base_layout::w, style::bell_base_layout::h);
@@ -176,12 +177,20 @@ namespace gui
             snoozeTimer->setVisible(false);
             alarm->informContentChanged();
             break;
-        case app::home_screen::HeaderViewMode::SnoozeCountdown:
+        case app::home_screen::HeaderViewMode::SnoozeIconAndTime:
             alarm->setVisible(false);
             alarm->setAlarmTimeVisible(false);
             snoozeTimer->setVisible(true);
+            snoozeTimer->setTimerVisible(true);
             snoozeTimer->informContentChanged();
             break;
+        case app::home_screen::HeaderViewMode::SnoozeIcon:
+            alarm->setVisible(false);
+            alarm->setAlarmTimeVisible(false);
+            snoozeTimer->setVisible(true);
+            snoozeTimer->informContentChanged();
+            snoozeTimer->setTimerVisible(false);
+            break;
         }
     }
 
diff --git a/products/BellHybrid/apps/common/include/common/models/AbstractAlarmModel.hpp b/products/BellHybrid/apps/common/include/common/models/AbstractAlarmModel.hpp
index 8debba8e1d7c980d57405e64ad493b9a661a9551..9c01a9f9c0b551816fac3bf285448b4240d8740a 100644
--- a/products/BellHybrid/apps/common/include/common/models/AbstractAlarmModel.hpp
+++ b/products/BellHybrid/apps/common/include/common/models/AbstractAlarmModel.hpp
@@ -4,6 +4,7 @@
 #pragma once
 
 #include <service-time/AlarmStatus.hpp>
+#include <time/dateCommon.hpp>
 
 #include <chrono>
 #include <ctime>
@@ -30,7 +31,7 @@ namespace app
         virtual void turnOff()                                 = 0;
         virtual void snooze()                                  = 0;
         virtual std::chrono::seconds getTimeToNextSnooze()     = 0;
-        virtual std::time_t getTimeOfNextSnooze()              = 0;
+        virtual TimePoint getTimeOfNextSnooze()                = 0;
         virtual alarms::AlarmStatus getAlarmStatus()           = 0;
         /// Command model to update its internal data
         virtual void update(AlarmModelReadyHandler callback = AlarmModelReadyHandler()) = 0;
diff --git a/products/BellHybrid/apps/common/include/common/models/AlarmModel.hpp b/products/BellHybrid/apps/common/include/common/models/AlarmModel.hpp
index 7242e7eaaf233a6eb3bc7d8df8c264c2e7995cb6..8788502278bc19cac7f829ad64eeeddc493ad353 100644
--- a/products/BellHybrid/apps/common/include/common/models/AlarmModel.hpp
+++ b/products/BellHybrid/apps/common/include/common/models/AlarmModel.hpp
@@ -38,7 +38,7 @@ namespace app
         void turnOff() override;
         void snooze() override;
         std::chrono::seconds getTimeToNextSnooze() override;
-        std::time_t getTimeOfNextSnooze() override;
+        TimePoint getTimeOfNextSnooze() override;
         alarms::AlarmStatus getAlarmStatus() override;
 
       private:
@@ -55,6 +55,9 @@ namespace app
         void disableSnooze(AlarmEventRecord &alarm);
         void updateCache(const SingleEventRecord &record, alarms::AlarmStatus status);
 
+        // Adjust snooze time basing on current time. If less than 15 sec - round down, if higher - round up
+        TimePoint calculateNextSnoozeTime(std::uint32_t desiredSnoozeTime);
+
         ApplicationCommon *app{};
         State state{State::Invalid};
         alarms::AlarmStatus alarmStatus{alarms::AlarmStatus::Invalid};
diff --git a/products/BellHybrid/apps/common/src/AlarmModel.cpp b/products/BellHybrid/apps/common/src/AlarmModel.cpp
index dcc6922a4b01e623232b175c8606e9e28662c987..3aaca7c719b4d1643a76b8a7618433f1e2455ef3 100644
--- a/products/BellHybrid/apps/common/src/AlarmModel.cpp
+++ b/products/BellHybrid/apps/common/src/AlarmModel.cpp
@@ -116,14 +116,27 @@ namespace app
         }
         return alarmEventPtr->enabled;
     }
+
+    TimePoint AlarmModel::calculateNextSnoozeTime(std::uint32_t desiredSnoozeTime)
+    {
+        const auto now     = TimePointNow();
+        const auto seconds = std::chrono::duration_cast<std::chrono::seconds>(now.time_since_epoch()).count();
+        if ((seconds % 60) <= 15) {
+            return std::chrono::floor<std::chrono::minutes>(now) + std::chrono::minutes(desiredSnoozeTime);
+        }
+        else {
+            return std::chrono::ceil<std::chrono::minutes>(now) + std::chrono::minutes(desiredSnoozeTime);
+        }
+    }
+
     std::chrono::seconds AlarmModel::getSnoozeDuration() const
     {
         const auto snoozeDurationStr =
             settings.getValue(bell::settings::Snooze::length, settings::SettingsScope::Global);
         const auto snoozeDuration = utils::getNumericValue<std::uint32_t>(snoozeDurationStr);
-
         return std::chrono::minutes{snoozeDuration};
     }
+
     bool AlarmModel::isSnoozeAllowed()
     {
         const auto snoozeActiveStr = settings.getValue(bell::settings::Snooze::active, settings::SettingsScope::Global);
@@ -139,12 +152,13 @@ namespace app
 
     void AlarmModel::snooze()
     {
+        snoozeCount++;
         const auto snoozeDurationStr =
             settings.getValue(bell::settings::Snooze::length, settings::SettingsScope::Global);
         const auto snoozeDuration = utils::getNumericValue<std::uint32_t>(snoozeDurationStr);
 
-        snoozeCount++;
-        nextSnoozeTime = std::chrono::ceil<std::chrono::minutes>(TimePointNow()) + std::chrono::minutes(snoozeDuration);
+        nextSnoozeTime = calculateNextSnoozeTime(snoozeDuration);
+
         alarms::AlarmServiceAPI::requestSnoozeRingingAlarm(app, cachedRecord.parent->ID, nextSnoozeTime);
         alarmStatus = alarms::AlarmStatus::Snoozed;
     }
@@ -204,12 +218,8 @@ namespace app
     {
         return alarmStatus;
     }
-    std::time_t AlarmModel::getTimeOfNextSnooze()
+    TimePoint AlarmModel::getTimeOfNextSnooze()
     {
-        const auto snoozeDurationStr =
-            settings.getValue(bell::settings::Snooze::length, settings::SettingsScope::Global);
-        const auto snoozeDuration = utils::getNumericValue<std::uint32_t>(snoozeDurationStr);
-        return Clock::to_time_t(std::chrono::floor<std::chrono::minutes>(TimePointNow()) +
-                                std::chrono::minutes(snoozeDuration));
+        return nextSnoozeTime;
     }
 } // namespace app