From d210ef00d131321b46f37b8da146eb8bb535ff4d Mon Sep 17 00:00:00 2001 From: Wojtek Rzepecki Date: Mon, 21 Dec 2020 09:26:57 +0100 Subject: [PATCH] [EGD-4952] Reverted usage of settings --- .../agents/settings/SystemSettings.hpp | 4 --- .../service-evtmgr/WorkerEvent.cpp | 2 -- .../battery-level-check/BatteryLevelCheck.cpp | 26 ++----------------- .../battery-level-check/BatteryLevelCheck.hpp | 2 -- 4 files changed, 2 insertions(+), 32 deletions(-) diff --git a/module-services/service-db/agents/settings/SystemSettings.hpp b/module-services/service-db/agents/settings/SystemSettings.hpp index 121c0664fa5cbf5e318ba3060a2e7a57411dd71a..d2ee288c3c2690263cbb1c9bda2af69cf6af77e1 100644 --- a/module-services/service-db/agents/settings/SystemSettings.hpp +++ b/module-services/service-db/agents/settings/SystemSettings.hpp @@ -22,9 +22,5 @@ namespace settings constexpr inline auto deviceName = "bt_device_name"; constexpr inline auto bondedDevices = "bt_bonded_devices"; } // namespace Bluetooth - namespace Battery - { - constexpr inline auto criticalLevel = "batt_critical_level"; - } // namespace Battery }; // namespace settings diff --git a/module-services/service-evtmgr/WorkerEvent.cpp b/module-services/service-evtmgr/WorkerEvent.cpp index 98411246d6759ac3979638218792bef7624e599e..cb38589a3fab7068066090c5548fbab13c2101dd 100644 --- a/module-services/service-evtmgr/WorkerEvent.cpp +++ b/module-services/service-evtmgr/WorkerEvent.cpp @@ -216,8 +216,6 @@ bool WorkerEvent::deinit(void) bsp::eink_frontlight::deinit(); bsp::light_sensor::deinit(); - battery_level_check::deinit(); - return true; } diff --git a/module-services/service-evtmgr/battery-level-check/BatteryLevelCheck.cpp b/module-services/service-evtmgr/battery-level-check/BatteryLevelCheck.cpp index 301a748ba30c35ed9042649a012142dd14d65ab0..060f1a6a5de4a012ce136b63f06bc9d6d57b5f6b 100644 --- a/module-services/service-evtmgr/battery-level-check/BatteryLevelCheck.cpp +++ b/module-services/service-evtmgr/battery-level-check/BatteryLevelCheck.cpp @@ -7,49 +7,28 @@ #include #include -#include -#include -#include namespace battery_level_check { namespace { constexpr inline auto DEFAULT_LEVEL = 10; + unsigned int batteryLevelCritical = DEFAULT_LEVEL; sys::Service *parentService = nullptr; - std::unique_ptr settings; - bool isBatteryLevelCritical(unsigned int level) { return level < batteryLevelCritical; } - void batteryLevelSettingsCallback(std::string setting) - { - if (!setting.empty()) { - batteryLevelCritical = utils::getNumericValue(setting); - } - else { - setBatteryCriticalLevel(DEFAULT_LEVEL); - } - } } // namespace void init(sys::Service *service) { parentService = service; - settings = std::make_unique(service); - settings->registerValueChange(settings::Battery::criticalLevel, - [&](std::string value) { batteryLevelSettingsCallback(value); }); - } - - void deinit() - { - settings->unregisterValueChange(settings::Battery::criticalLevel); - settings.reset(); + checkBatteryLevelCritical(); } void checkBatteryLevelCritical() @@ -65,7 +44,6 @@ namespace battery_level_check void setBatteryCriticalLevel(unsigned int level) { batteryLevelCritical = level; - settings->setValue(settings::Battery::criticalLevel, std::to_string(batteryLevelCritical)); checkBatteryLevelCritical(); } diff --git a/module-services/service-evtmgr/battery-level-check/BatteryLevelCheck.hpp b/module-services/service-evtmgr/battery-level-check/BatteryLevelCheck.hpp index 7bf454cb998e48eab65550847e88890b3f6f7ca1..964b4371c6608f50138a44cee3ea164a85677d32 100644 --- a/module-services/service-evtmgr/battery-level-check/BatteryLevelCheck.hpp +++ b/module-services/service-evtmgr/battery-level-check/BatteryLevelCheck.hpp @@ -14,8 +14,6 @@ namespace battery_level_check { void init(sys::Service *service); - void deinit(); - void checkBatteryLevelCritical(); void setBatteryCriticalLevel(unsigned int level);