~aleteoryx/muditaos

df7535f10afe6d1c74b0dfcb2f5808711e96e725 — rrandomsky 2 years ago d403db4
[MOS-948] Revert: Fix for tethering popup was losing app context

Reverting previous fix because when tethering is switched on the user
are not able to use phone features, and we this fix make the user
to pass this block and it would make their confuse.
M module-apps/apps-common/popups/TetheringConfirmationPopup.cpp => module-apps/apps-common/popups/TetheringConfirmationPopup.cpp +2 -1
@@ 6,6 6,7 @@
#include "ApplicationCommon.hpp"

#include <system/messages/TetheringQuestionRequest.hpp>
#include <service-appmgr/Controller.hpp>

namespace gui
{


@@ 22,7 23,7 @@ namespace gui
        metadata.action = [this]() {
            application->bus.sendUnicast(std::make_shared<sys::TetheringEnabledResponse>(),
                                         service::name::system_manager);
            application->returnToPreviousWindow();
            app::manager::Controller::sendAction(application, app::manager::actions::Home);
            return true;
        };
        auto msg = std::make_unique<DialogMetadataMessage>(std::move(metadata));

M module-apps/apps-common/popups/TetheringOffPopup.cpp => module-apps/apps-common/popups/TetheringOffPopup.cpp +2 -1
@@ 6,6 6,7 @@
#include <messages/DialogMetadataMessage.hpp>
#include <apps-common/ApplicationCommon.hpp>
#include <system/messages/TetheringStateRequest.hpp>
#include <service-appmgr/Controller.hpp>

namespace gui
{


@@ 32,7 33,7 @@ namespace gui
        metadata.action = [this]() {
            application->bus.sendUnicast(std::make_shared<sys::TetheringStateRequest>(sys::phone_modes::Tethering::Off),
                                         service::name::system_manager);
            application->returnToPreviousWindow();
            app::manager::Controller::sendAction(application, app::manager::actions::Home);
            return true;
        };
        metadata.title = utils::translate("tethering");

M pure_changelog.md => pure_changelog.md +0 -1
@@ 29,7 29,6 @@
* Fixed ability to create contact with 2 same numbers
* Fixed diacritics in translations
* Fixed issues with file uploads with low disk space.
* Fixed data losing because switching tethering via tethering popup
* Fixed hard fault handling
* Fixed issue with uneven first screen redraw after turning the phone on
* Fixed issue with bypassing phone lock window after unplugging USB cable on tethering popup