From efef3c368c389fc9f9eb4318b474be6aef655080 Mon Sep 17 00:00:00 2001
From: Alek Rudnik <aleksander.rudnik@mudita.com>
Date: Fri, 5 Mar 2021 16:34:56 +0100
Subject: [PATCH] [EGD-6043] Change status bar layout

Status bar is rewritten to use box layout
---
 module-apps/windows/AppWindow.cpp             |  6 +-
 module-gui/gui/widgets/Style.hpp              |  9 ++-
 module-gui/gui/widgets/TopBar.cpp             | 72 +++++++++++--------
 module-gui/gui/widgets/TopBar.hpp             |  7 +-
 module-gui/gui/widgets/TopBar/BatteryBar.cpp  |  2 +
 module-gui/gui/widgets/TopBar/BatteryBase.cpp |  3 +-
 module-gui/gui/widgets/TopBar/BatteryBase.hpp |  2 +-
 module-gui/gui/widgets/TopBar/BatteryText.cpp | 10 +--
 .../TopBar/NetworkAccessTechnology.cpp        |  9 +--
 .../gui/widgets/TopBar/SignalStrengthBar.cpp  |  3 +-
 .../gui/widgets/TopBar/SignalStrengthBase.cpp |  3 +-
 .../gui/widgets/TopBar/SignalStrengthText.cpp | 10 +--
 module-gui/gui/widgets/TopBar/Style.hpp       | 61 ++++++++++++++++
 module-gui/gui/widgets/TopBar/Time.cpp        |  4 +-
 14 files changed, 147 insertions(+), 54 deletions(-)
 create mode 100644 module-gui/gui/widgets/TopBar/Style.hpp

diff --git a/module-apps/windows/AppWindow.cpp b/module-apps/windows/AppWindow.cpp
index 85daebfca033c0bd6fc2764635a8c05e51e47128..d41325969490b731e724e6264dc7f40982087e90 100644
--- a/module-apps/windows/AppWindow.cpp
+++ b/module-apps/windows/AppWindow.cpp
@@ -50,8 +50,10 @@ namespace gui
         title->setEllipsis(Ellipsis::Right);
         title->visible = false;
 
-        auto config = configureTopBar(application->getTopBarConfiguration());
-        topBar      = new gui::top_bar::TopBar(this, 0, 0, 480, 50);
+        auto config          = configureTopBar(application->getTopBarConfiguration());
+        namespace status_bar = style::header::status_bar;
+        topBar               = new gui::top_bar::TopBar(
+            this, (style::window_width - status_bar::width) / 2, 0, status_bar::width, status_bar::height);
         topBar->configure(std::move(config));
     }
 
diff --git a/module-gui/gui/widgets/Style.hpp b/module-gui/gui/widgets/Style.hpp
index f1a7c6edc886957b47d9b00c3ea1a0d12a967099..4c24af41ff0197c207601ab7c365a2def71f722c 100644
--- a/module-gui/gui/widgets/Style.hpp
+++ b/module-gui/gui/widgets/Style.hpp
@@ -23,10 +23,13 @@ namespace style
     namespace header
     {
         inline constexpr auto height = 105U;
+        namespace status_bar
+        {
+            inline constexpr auto height = 46U;
+            inline constexpr auto width  = 440U;
+        }; // namespace status_bar
         namespace font
         {
-            inline constexpr auto time  = "gt_pressura_regular_24";
-            inline constexpr auto modes = "gt_pressura_regular_20";
             inline constexpr auto title = "gt_pressura_bold_32";
         }; // namespace font
     };     // namespace header
@@ -92,7 +95,7 @@ namespace style
             inline constexpr auto h = 54U;
             inline constexpr auto w = window_width;
         } // namespace bottomBar
-    }; // namespace window
+    };    // namespace window
 
     namespace settings
     {
diff --git a/module-gui/gui/widgets/TopBar.cpp b/module-gui/gui/widgets/TopBar.cpp
index dc8787a768a2b584156d7eaa57a3d339fbf65855..d78c6d32238b41b19d1f338576d2c48dd839e7ac 100644
--- a/module-gui/gui/widgets/TopBar.cpp
+++ b/module-gui/gui/widgets/TopBar.cpp
@@ -5,9 +5,10 @@
 #include <iomanip>
 #include "Label.hpp"
 #include "Image.hpp"
+#include "BoxLayout.hpp"
 #include "TopBar.hpp"
 #include <time/time_conversion.hpp>
-#include "Style.hpp"
+#include "TopBar/Style.hpp"
 #include "TopBar/BatteryBar.hpp"
 #include "TopBar/BatteryText.hpp"
 #include "TopBar/SignalStrengthBar.hpp"
@@ -21,22 +22,13 @@
 
 namespace gui::top_bar
 {
+    using namespace style::header::status_bar;
+
     constexpr auto batteryWidgetAsText = true;
     using BatteryType                  = std::conditional<batteryWidgetAsText, BatteryText, BatteryBar>::type;
     constexpr auto signalWidgetAsText  = true;
     using SignalType = std::conditional<signalWidgetAsText, SignalStrengthText, SignalStrengthBar>::type;
 
-    namespace networkTechnology
-    {
-        constexpr uint32_t x = 100;
-        constexpr uint32_t y = 21;
-        constexpr uint32_t w = 130;
-        constexpr uint32_t h = 20;
-    } // namespace networkTechnology
-
-    static constexpr uint32_t signalOffset  = 20;
-    static constexpr uint32_t batteryOffset = 413;
-
     void Configuration::enable(Indicator indicator)
     {
         set(indicator, true);
@@ -79,14 +71,12 @@ namespace gui::top_bar
         return indicatorStatuses;
     }
 
-    TopBar::TopBar(Item *parent, uint32_t x, uint32_t y, uint32_t w, uint32_t h) : Rect{parent, x, y, w, h}
+    TopBar::TopBar(Item *parent, uint32_t x, uint32_t y, uint32_t w, uint32_t h) : HBox{parent, x, y, w, h}
     {
         prepareWidget();
 
-        setFillColor(ColorFullWhite);
-        setBorderColor(ColorNoColor);
-        setFilled(true);
-        setSize(480, 50);
+        setEdges(RectangleEdge::None);
+        setAlignment(Alignment(Alignment::Horizontal::Center));
         updateDrawArea();
 
         preBuildDrawListHook = [this](std::list<Command> &) { updateTime(); };
@@ -94,17 +84,38 @@ namespace gui::top_bar
 
     void TopBar::prepareWidget()
     {
-        battery                      = new BatteryType(this, batteryOffset, 15, 60, 24);
-        signal                       = new SignalType(this, signalOffset, 17, 70, 24);
-        const auto design_sim_offset = 376; // this offset is not final, but it is pixel Purefect
-        sim                          = new SIM(this, design_sim_offset, 12);
-
-        lock = new Lock(this, 240 - 11, 17);
-
-        time = new Time(this, 0, 0, 480, this->drawArea.h);
-
-        networkAccessTechnology = new NetworkAccessTechnology(
-            this, networkTechnology::x, networkTechnology::y, networkTechnology::w, networkTechnology::h);
+        // left
+        leftBox = new HBox(this, 0, 0, 0, 0);
+        leftBox->setMinimumSize(boxes::left::minX, this->drawArea.h);
+        leftBox->setMaximumSize(boxes::left::maxX, this->drawArea.h);
+        leftBox->setAlignment(Alignment(Alignment::Horizontal::Left, Alignment::Vertical::Bottom));
+        leftBox->setEdges(RectangleEdge::None);
+        signal = new SignalType(leftBox, 0, 0, 0, 0);
+        signal->setMargins(gui::Margins(margins::between, 0, 0, margins::iconBottom));
+        networkAccessTechnology = new NetworkAccessTechnology(leftBox, 0, 0, 0, 0);
+        networkAccessTechnology->setMaximumSize(nat::maxX, this->drawArea.h);
+        networkAccessTechnology->setMargins(gui::Margins(margins::between, 0, 0, margins::textBottom));
+
+        // center
+        centralBox = new HBox(this, 0, 0, 0, 0);
+        centralBox->setAlignment(Alignment(Alignment::Horizontal::Center, Alignment::Vertical::Bottom));
+        centralBox->setEdges(RectangleEdge::None);
+        lock = new Lock(centralBox, 0, 0);
+        lock->setMargins(Margins(0, 0, 0, margins::iconBottom));
+        time = new Time(centralBox, 0, 0, 0, 0);
+        time->setMaximumSize(time::maxX, this->drawArea.h);
+
+        // right
+        rightBox = new HBox(this, 0, 0, 0, 0);
+        rightBox->setMinimumSize(boxes::right::minX, this->drawArea.h);
+        rightBox->setMaximumSize(boxes::right::maxX, this->drawArea.h);
+        rightBox->setAlignment(Alignment(Alignment::Horizontal::Right, Alignment::Vertical::Bottom));
+        rightBox->setEdges(RectangleEdge::None);
+        rightBox->setReverseOrder(true);
+        battery = new BatteryType(rightBox, 0, 0, 0, 0);
+        battery->setMargins(gui::Margins(0, 0, margins::between, margins::iconBottom));
+        sim = new SIM(rightBox, 0, 0);
+        sim->setMargins(gui::Margins(0, 0, margins::between, margins::iconBottom));
 
         updateSignalStrength();
         updateNetworkAccessTechnology();
@@ -131,6 +142,8 @@ namespace gui::top_bar
             setIndicatorStatus(indicator, enabled);
         }
         configuration = std::move(config);
+
+        resizeItems();
     }
 
     void TopBar::setIndicatorStatus(Indicator indicator, bool enabled)
@@ -222,8 +235,10 @@ namespace gui::top_bar
     {
         time->update();
         if (enabled) {
+            centralBox->setMinimumSize(boxes::center::maxX, this->drawArea.h);
             time->show();
             lock->hide();
+            centralBox->resizeItems();
             return;
         }
         time->hide();
@@ -232,6 +247,7 @@ namespace gui::top_bar
     void TopBar::showLock(bool enabled)
     {
         if (enabled) {
+            centralBox->setMinimumSize(boxes::center::minX, this->drawArea.h);
             lock->show();
             time->hide();
             return;
diff --git a/module-gui/gui/widgets/TopBar.hpp b/module-gui/gui/widgets/TopBar.hpp
index 4306f13e7c9bcba2c261ae1f130051adf9fe1205..6ed45b710c30b72b77cdd64bd0a6dd313885ca61 100644
--- a/module-gui/gui/widgets/TopBar.hpp
+++ b/module-gui/gui/widgets/TopBar.hpp
@@ -3,7 +3,7 @@
 
 #pragma once
 
-#include <Rect.hpp>
+#include <BoxLayout.hpp>
 #include <vector>
 #include <map>
 
@@ -71,7 +71,7 @@ namespace gui::top_bar
     };
 
     /// Header of most of design Windows
-    class TopBar : public Rect
+    class TopBar : public HBox
     {
       protected:
         Time *time                                       = nullptr;
@@ -80,6 +80,9 @@ namespace gui::top_bar
         Lock *lock                                       = nullptr;
         SIM *sim                                         = nullptr;
         BatteryBase *battery                             = nullptr;
+        HBox *leftBox                                    = nullptr;
+        HBox *centralBox                                 = nullptr;
+        HBox *rightBox                                   = nullptr;
         Configuration configuration;
 
         void prepareWidget();
diff --git a/module-gui/gui/widgets/TopBar/BatteryBar.cpp b/module-gui/gui/widgets/TopBar/BatteryBar.cpp
index 877c02dddb8661ee64d868f683f0e650e3e8bcfc..7e5ddb5309881e97f5b370177c58086eb55ad690 100644
--- a/module-gui/gui/widgets/TopBar/BatteryBar.cpp
+++ b/module-gui/gui/widgets/TopBar/BatteryBar.cpp
@@ -31,6 +31,8 @@ namespace gui::top_bar
         : BatteryBase(parent, x, y, w, h)
     {
         img = new Image(this, battery1);
+
+        setMinimumSize(img->getWidth(), style::header::status_bar::height);
     }
 
     void BatteryBar::showBatteryLevel(std::uint32_t percentage)
diff --git a/module-gui/gui/widgets/TopBar/BatteryBase.cpp b/module-gui/gui/widgets/TopBar/BatteryBase.cpp
index ee044476f804e33649f4762eebb0a1872f8a01f6..095d81ed0f19f442d08f468ea4b3de40f5353ec2 100644
--- a/module-gui/gui/widgets/TopBar/BatteryBase.cpp
+++ b/module-gui/gui/widgets/TopBar/BatteryBase.cpp
@@ -9,7 +9,8 @@ namespace gui::top_bar
     BatteryBase::BatteryBase(Item *parent, uint32_t x, uint32_t y, uint32_t w, uint32_t h)
         : StatusBarWidgetBase(parent, x, y, w, h)
     {
-        setBorderColor(gui::ColorNoColor);
+        setEdges(RectangleEdge::None);
+        setAlignment(Alignment(Alignment::Horizontal::Right, Alignment::Vertical::Bottom));
     }
 
     void BatteryBase::update(const Store::Battery &batteryContext)
diff --git a/module-gui/gui/widgets/TopBar/BatteryBase.hpp b/module-gui/gui/widgets/TopBar/BatteryBase.hpp
index ef81efe655b851ebca4d19096c0523ddfe1d556e..2a0bf7f72c1e87a387db42901707fa31feaad8a8 100644
--- a/module-gui/gui/widgets/TopBar/BatteryBase.hpp
+++ b/module-gui/gui/widgets/TopBar/BatteryBase.hpp
@@ -9,7 +9,7 @@
 
 namespace gui::top_bar
 {
-    class BatteryBase : public StatusBarWidgetBase<HBox>
+    class BatteryBase : public StatusBarWidgetBase<gui::HBox>
     {
         virtual void showBatteryLevel(std::uint32_t percentage) = 0;
         virtual void showBatteryChargingDone()                  = 0;
diff --git a/module-gui/gui/widgets/TopBar/BatteryText.cpp b/module-gui/gui/widgets/TopBar/BatteryText.cpp
index 4b12f9512abb05d9cb5a94b62c9dc9d83859909a..f57c4e4adf6f06de039c87adb1503e8793731bc7 100644
--- a/module-gui/gui/widgets/TopBar/BatteryText.cpp
+++ b/module-gui/gui/widgets/TopBar/BatteryText.cpp
@@ -4,7 +4,7 @@
 #include "BatteryText.hpp"
 #include "Label.hpp"
 #include <Utils.hpp>
-#include <Style.hpp>
+#include "Style.hpp"
 
 namespace gui::top_bar
 {
@@ -14,9 +14,11 @@ namespace gui::top_bar
         label = new Label(this, 0, 0, 0, 0);
         label->setFilled(false);
         label->setBorderColor(gui::ColorNoColor);
-        label->setFont(style::header::font::modes);
-        label->setAlignment(gui::Alignment(gui::Alignment::Horizontal::Left, gui::Alignment::Vertical::Center));
-        label->setMaximumSize(this->getWidth(), this->getHeight());
+        label->setFont(style::header::status_bar::battery::font);
+        label->setAlignment(gui::Alignment(gui::Alignment::Horizontal::Right, gui::Alignment::Vertical::Bottom));
+
+        setMinimumSize(style::header::status_bar::battery::maxX, style::header::status_bar::height);
+        label->setMaximumSize(style::header::status_bar::battery::maxX, style::header::status_bar::height);
     }
 
     void BatteryText::showBatteryLevel(std::uint32_t percentage)
diff --git a/module-gui/gui/widgets/TopBar/NetworkAccessTechnology.cpp b/module-gui/gui/widgets/TopBar/NetworkAccessTechnology.cpp
index 0cabdcaf434f3ea7406b49d3b28b6e41e7ffbcc0..8fa3bc2d448690b63029a355edf6e2147e66e476 100644
--- a/module-gui/gui/widgets/TopBar/NetworkAccessTechnology.cpp
+++ b/module-gui/gui/widgets/TopBar/NetworkAccessTechnology.cpp
@@ -3,20 +3,21 @@
 
 #include "NetworkAccessTechnology.hpp"
 #include "Item.hpp"
+#include "Style.hpp"
 
 namespace gui::top_bar
 {
     NetworkAccessTechnology::NetworkAccessTechnology(Item *parent, uint32_t x, uint32_t y, uint32_t w, uint32_t h)
         : StatusBarWidgetBase(parent, x, y, w, h)
     {
-        setFilled(false);
-        setBorderColor(gui::ColorNoColor);
-        setFont(style::header::font::modes);
-        setAlignment(gui::Alignment(gui::Alignment::Horizontal::Left, gui::Alignment::Vertical::Center));
+        setEdges(RectangleEdge::None);
+        setFont(style::header::status_bar::nat::font);
+        setAlignment(gui::Alignment(gui::Alignment::Horizontal::Left, gui::Alignment::Vertical::Bottom));
     }
 
     void NetworkAccessTechnology::update(const Store::Network::AccessTechnology accessTechnology)
     {
+        setMaximumSize(this->getWidth(), this->getHeight());
         _accessTechnology      = accessTechnology;
         constexpr auto text2g  = "2G";
         constexpr auto text3g  = "3G";
diff --git a/module-gui/gui/widgets/TopBar/SignalStrengthBar.cpp b/module-gui/gui/widgets/TopBar/SignalStrengthBar.cpp
index ae2a21a800ff59e15f91440dd1fdd68caa782062..454eacdc344f9a4174a8fe832f1fed1a422bc488 100644
--- a/module-gui/gui/widgets/TopBar/SignalStrengthBar.cpp
+++ b/module-gui/gui/widgets/TopBar/SignalStrengthBar.cpp
@@ -30,8 +30,7 @@ namespace gui::top_bar
         : SignalStrengthBase(parent, x, y, w, h)
     {
         img                             = new Image(this, signalMap.at(Store::RssiBar::zero));
-        constexpr auto signalBarMarginX = 10u;
-        img->setMargins(gui::Margins(signalBarMarginX, 0, 0, 0));
+        setMinimumSize(img->getWidth(), style::header::status_bar::height);
     }
 
     void SignalStrengthBar::update()
diff --git a/module-gui/gui/widgets/TopBar/SignalStrengthBase.cpp b/module-gui/gui/widgets/TopBar/SignalStrengthBase.cpp
index f712e4c689844c0e99cb295c0569494b6fa20bd7..b5cfe8f8c2b87b510274e3f2e7ea5d34e8f4d278 100644
--- a/module-gui/gui/widgets/TopBar/SignalStrengthBase.cpp
+++ b/module-gui/gui/widgets/TopBar/SignalStrengthBase.cpp
@@ -8,7 +8,8 @@ namespace gui::top_bar
     SignalStrengthBase::SignalStrengthBase(Item *parent, uint32_t x, uint32_t y, uint32_t w, uint32_t h)
         : StatusBarWidgetBase(parent, x, y, w, h)
     {
-        setBorderColor(gui::ColorNoColor);
+        setEdges(RectangleEdge::None);
+        setAlignment(Alignment(Alignment::Horizontal::Left, Alignment::Vertical::Bottom));
     }
 
     void SignalStrengthBase::update(const Store::SignalStrength &data)
diff --git a/module-gui/gui/widgets/TopBar/SignalStrengthText.cpp b/module-gui/gui/widgets/TopBar/SignalStrengthText.cpp
index a3a62c14b377f6ca2a47a80dc613cc58441a4e37..d609891fa5f04e047295251a51782214e90b9950 100644
--- a/module-gui/gui/widgets/TopBar/SignalStrengthText.cpp
+++ b/module-gui/gui/widgets/TopBar/SignalStrengthText.cpp
@@ -5,7 +5,7 @@
 #include "Label.hpp"
 #include "common_data/EventStore.hpp"
 #include <Utils.hpp>
-#include <Style.hpp>
+#include "Style.hpp"
 
 namespace gui::top_bar
 {
@@ -15,9 +15,11 @@ namespace gui::top_bar
         label = new Label(this, 0, 0, 0, 0);
         label->setFilled(false);
         label->setBorderColor(gui::ColorNoColor);
-        label->setFont(style::header::font::modes);
-        label->setAlignment(gui::Alignment(gui::Alignment::Horizontal::Left, gui::Alignment::Vertical::Center));
-        label->setMaximumSize(this->getWidth(), this->getHeight());
+        label->setFont(style::header::status_bar::signal::font);
+        label->setAlignment(gui::Alignment(gui::Alignment::Horizontal::Left, gui::Alignment::Vertical::Bottom));
+
+        setMinimumSize(style::header::status_bar::signal::maxX, style::header::status_bar::height);
+        label->setMaximumSize(style::header::status_bar::signal::maxX, style::header::status_bar::height);
     }
 
     void SignalStrengthText::update()
diff --git a/module-gui/gui/widgets/TopBar/Style.hpp b/module-gui/gui/widgets/TopBar/Style.hpp
new file mode 100644
index 0000000000000000000000000000000000000000..61c07e830073cd3f116fe515765f588e10e1c6f5
--- /dev/null
+++ b/module-gui/gui/widgets/TopBar/Style.hpp
@@ -0,0 +1,61 @@
+// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved.
+// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md
+
+#pragma once
+
+#include <Style.hpp>
+
+namespace style::header::status_bar
+{
+    namespace font
+    {
+
+        inline constexpr auto title = "gt_pressura_bold_32";
+    }; // namespace font
+
+    namespace margins
+    {
+        inline constexpr auto iconBottom = 4u;
+        inline constexpr auto textBottom = 5u;
+        inline constexpr auto between    = 10u;
+    }; // namespace margins
+    namespace time
+    {
+        inline constexpr auto font = "gt_pressura_regular_24";
+        inline constexpr auto maxX = 100u;
+    }; // namespace time
+    namespace nat
+    {
+        inline constexpr auto maxX = 35u;
+        inline constexpr auto font = "gt_pressura_regular_20";
+    }; // namespace nat
+    namespace signal
+    {
+        inline constexpr auto font = "gt_pressura_regular_20";
+        inline constexpr auto maxX = 80u;
+    }; // namespace signal
+    namespace battery
+    {
+        inline constexpr auto font = "gt_pressura_regular_20";
+        inline constexpr auto maxX = 70U;
+    }; // namespace battery
+    namespace boxes
+    {
+        namespace left
+        {
+            inline constexpr auto minX = 165u;
+            inline constexpr auto maxX = 205u;
+        }; // namespace left
+        namespace right
+        {
+            inline constexpr auto minX = 165u;
+            inline constexpr auto maxX = 205u;
+        }; // namespace right
+        namespace center
+        {
+            inline constexpr auto maxX = time::maxX;
+            inline constexpr auto minX = 30;
+        }; // namespace center
+    };     // namespace boxes
+
+}; // namespace style::header::status_bar
diff --git a/module-gui/gui/widgets/TopBar/Time.cpp b/module-gui/gui/widgets/TopBar/Time.cpp
index 89cccb231389ddbabd909d27b8bc4d304f435bdf..4c5d02beb23bd98b4e68251c164d27bb35069a27 100644
--- a/module-gui/gui/widgets/TopBar/Time.cpp
+++ b/module-gui/gui/widgets/TopBar/Time.cpp
@@ -4,7 +4,7 @@
 #include "Time.hpp"
 #include "time/time_conversion.hpp"
 #include <Utils.hpp>
-#include <Style.hpp>
+#include "Style.hpp"
 
 namespace gui::top_bar
 {
@@ -13,7 +13,7 @@ namespace gui::top_bar
     {
         setFilled(false);
         setBorderColor(gui::ColorNoColor);
-        setFont(style::header::font::time);
+        setFont(style::header::status_bar::time::font);
         setAlignment(gui::Alignment(gui::Alignment::Horizontal::Center, gui::Alignment::Vertical::Center));
         using namespace utils::time;
         setFormat(Locale::format(Locale::TimeFormat::FormatTime12H));