~aleteoryx/muditaos

f96a1be47453c4d9027ae322661160331291b56b — Paweł Joński 4 years ago 5344c5c
[BH-367] Convert UCS2 to library

Convert UCS2 to library,
move tests from module-utils/test to UCS2 folder
M enabled_unittests => enabled_unittests +1 -1
@@ 363,7 363,7 @@ TESTS_LIST["catch2-utils-time_display"]="
    Time display parser;
"
#---------
TESTS_LIST["catch2-utils-ucs2"]="
TESTS_LIST["catch2-ucs2"]="
    UCS2 to UTF8 conversion;
    UCS2 from UTF8 emoji 😁;
    UCS2 from UTF8 emoji 🍣;

M module-services/service-cellular/CMakeLists.txt => module-services/service-cellular/CMakeLists.txt +1 -0
@@ 54,6 54,7 @@ target_link_libraries(${PROJECT_NAME}
        service-antenna
        service-audio
        service-evtmgr
        ucs2
    PUBLIC
        time
        utf8

M module-utils/CMakeLists.txt => module-utils/CMakeLists.txt +2 -1
@@ 18,7 18,6 @@ add_subdirectory(EventStore)
set (SOURCES
        ${CMAKE_CURRENT_SOURCE_DIR}/i18n/i18n.cpp
        ${CMAKE_CURRENT_SOURCE_DIR}/json/json11.cpp
        ${CMAKE_CURRENT_SOURCE_DIR}/ucs2/UCS2.cpp
        ${CMAKE_CURRENT_SOURCE_DIR}/PhoneNumber.cpp
        ${CMAKE_CURRENT_SOURCE_DIR}/PhoneNumber.hpp
        ${CMAKE_CURRENT_SOURCE_DIR}/NumberHolderMatcher.hpp


@@ 76,4 75,6 @@ add_subdirectory(board)
add_subdirectory(bootconfig)
add_subdirectory(log)
add_subdirectory(time)
add_subdirectory(ucs2)
add_subdirectory(utf8)


M module-utils/test/CMakeLists.txt => module-utils/test/CMakeLists.txt +0 -10
@@ 20,16 20,6 @@ add_catch2_executable(
        module-utils
)

# UCS2 tests
add_catch2_executable(
    NAME
        utils-ucs2
    SRCS
        unittest_ucs2.cpp
    LIBS
        module-utils
)

# duration tests
add_catch2_executable(
    NAME

A module-utils/ucs2/CMakeLists.txt => module-utils/ucs2/CMakeLists.txt +25 -0
@@ 0,0 1,25 @@
add_library(ucs2 STATIC)

module_is_test_entity(ucs2)

target_sources(ucs2
    PRIVATE
       ucs2/UCS2.cpp
)

target_include_directories(ucs2
    PUBLIC
        $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
)

target_link_libraries(ucs2
    PUBLIC
        utf8

    PRIVATE
        log
)

if (${ENABLE_TESTS})
    add_subdirectory( test )
endif()

A module-utils/ucs2/test/CMakeLists.txt => module-utils/ucs2/test/CMakeLists.txt +8 -0
@@ 0,0 1,8 @@
add_catch2_executable(
    NAME
        ucs2
    SRCS
        unittest_ucs2.cpp
    LIBS
        ucs2
)

R module-utils/test/unittest_ucs2.cpp => module-utils/ucs2/test/unittest_ucs2.cpp +2 -2
@@ 1,10 1,10 @@
// Copyright (c) 2017-2020, Mudita Sp. z.o.o. All rights reserved.
// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved.
// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md

#define CATCH_CONFIG_MAIN // This tells Catch to provide a main() - only do this in one cpp file
#include <catch2/catch.hpp>

#include "ucs2/UCS2.hpp"
#include <ucs2/UCS2.hpp>

TEST_CASE("UCS2 to UTF8 conversion")
{

R module-utils/ucs2/UCS2.cpp => module-utils/ucs2/ucs2/UCS2.cpp +1 -2
@@ 18,8 18,7 @@ namespace ucs2
} // namespace ucs2

UCS2::UCS2() : sizeAllocated{ucs2::bufferExt}, buffer{std::make_unique<uint32_t[]>(ucs2::bufferExt)}
{
}
{}

UCS2::UCS2(const UTF8 &string)
{

R module-utils/ucs2/UCS2.hpp => module-utils/ucs2/ucs2/UCS2.hpp +1 -1
@@ 5,7 5,7 @@

#include <cstdint>
#include <memory>
#include "utf8/UTF8.hpp"
#include <utf8/UTF8.hpp>

class UCS2
{