~aleteoryx/muditaos

06ef1e131b27b0f397cc615c96d51bede7050423 — Marcin Lyda 4 years ago dfde2e1
[MOS-300] Remove unused variables

Remove unused variables from PVS Studio analysis
M module-bluetooth/Bluetooth/interface/profiles/A2DP/A2DP.cpp => module-bluetooth/Bluetooth/interface/profiles/A2DP/A2DP.cpp +1 -2
@@ 1,4 1,4 @@
// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved.
// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved.
// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md

//


@@ 329,7 329,6 @@ namespace bluetooth
            a2dp_subevent_signaling_connection_established_get_bd_addr(packet, address);
            cid    = a2dp_subevent_signaling_connection_established_get_a2dp_cid(packet);
            status = a2dp_subevent_signaling_connection_established_get_status(packet);
            std::string deviceAddress{bd_addr_to_str(address)};
            if (status != ERROR_CODE_SUCCESS) {
                LOG_INFO("A2DP Source: Connection failed, status 0x%02x, cid 0x%02x, a2dp_cid 0x%02x \n",
                         status,

M module-services/service-audio/AudioServiceAPI.cpp => module-services/service-audio/AudioServiceAPI.cpp +1 -2
@@ 1,4 1,4 @@
// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved.
// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved.
// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md

#include <AudioMessage.hpp>


@@ 221,7 221,6 @@ namespace AudioServiceAPI

    std::optional<audio::Volume> GetVolume(sys::Service *serv, audio::PlaybackType playbackType)
    {
        std::optional<audio::Volume> volume;
        try {
            return static_cast<audio::Volume>(std::stoi(GetSetting(serv, audio::Setting::Volume, playbackType)));
        }

M module-services/service-cellular/NetworkSettings.cpp => module-services/service-cellular/NetworkSettings.cpp +1 -2
@@ 1,4 1,4 @@
// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved.
// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved.
// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md

#include "NetworkSettings.hpp"


@@ 260,7 260,6 @@ at::Result::Code NetworkSettings::setPreferredSMSDomain(SMSDomainPreference pref

at::Result::Code NetworkSettings::setIMSState(at::response::qcfg_ims::IMSState state)
{
    std::vector<std::string> operatorNames;
    auto channel = cellularService.cmux->get(CellularMux::Channel::Commands);
    if (!channel) {
        return at::Result::Code::ERROR;

M products/BellHybrid/apps/application-bell-settings/models/alarm_settings/AlarmSettingsModel.cpp => products/BellHybrid/apps/application-bell-settings/models/alarm_settings/AlarmSettingsModel.cpp +0 -1
@@ 20,7 20,6 @@ namespace app::bell_settings

    void AlarmVolumeModel::setValue(std::uint8_t value)
    {
        const auto valStr = std::to_string(value);
        audioModel.setVolume(value, AbstractAudioModel::PlaybackType::Alarm, {});
    }


M products/BellHybrid/apps/application-bell-settings/models/alarm_settings/PrewakeUpSettingsModel.cpp => products/BellHybrid/apps/application-bell-settings/models/alarm_settings/PrewakeUpSettingsModel.cpp +1 -2
@@ 1,4 1,4 @@
// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved.
// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved.
// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md

#include <models/alarm_settings/PrewakeUpSettingsModel.hpp>


@@ 32,7 32,6 @@ namespace app::bell_settings

    void PrewakeUpChimeVolumeModel::setValue(std::uint8_t value)
    {
        const auto valStr = std::to_string(value);
        audioModel.setVolume(value, AbstractAudioModel::PlaybackType::PreWakeup, {});
    }


M products/BellHybrid/apps/application-bell-settings/models/alarm_settings/SnoozeSettingsModel.cpp => products/BellHybrid/apps/application-bell-settings/models/alarm_settings/SnoozeSettingsModel.cpp +1 -2
@@ 1,4 1,4 @@
// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved.
// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved.
// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md

#include <models/alarm_settings/SnoozeSettingsModel.hpp>


@@ 73,7 73,6 @@ namespace app::bell_settings

    void SnoozeChimeVolumeModel::setValue(std::uint8_t value)
    {
        const auto valStr = std::to_string(value);
        audioModel.setVolume(value, AbstractAudioModel::PlaybackType::Snooze, {});
    }


M products/BellHybrid/apps/common/src/models/BedtimeModel.cpp => products/BellHybrid/apps/common/src/models/BedtimeModel.cpp +1 -2
@@ 1,4 1,4 @@
// Copyright (c) 2017-2021, Mudita Sp. z.o.o. All rights reserved.
// Copyright (c) 2017-2022, Mudita Sp. z.o.o. All rights reserved.
// For licensing, see https://github.com/mudita/MuditaOS/LICENSE.md

#include "models/BedtimeModel.hpp"


@@ 77,7 77,6 @@ namespace app::bell_bedtime

    void BedtimeVolumeModel::setValue(std::uint8_t value)
    {
        const auto valStr = std::to_string(value);
        audioModel.setVolume(value, AbstractAudioModel::PlaybackType::Bedtime, {});
    }