~aleteoryx/muditaos: [MOS-769] Make a destructor virtual

cf1ec5d1029ee40b1f14a816525c5eb99d67e0b0 — Marcin Zieliński 3 years ago 8f420ec

[MOS-769] Make a destructor virtual

Make Make gui::popup::Filter's destructor
virtual because it has a virtual method.

Additionally, added a documenting comment.

patch browse .tar.gz

1 files changed, 3 insertions(+), 0 deletions(-)

M module-apps/apps-common/WindowsPopupFilter.hpp

M module-apps/apps-common/WindowsPopupFilter.hpp => module-apps/apps-common/WindowsPopupFilter.hpp +3 -0

@@ 22,9 22,12 @@ namespace gui::popup
     {
       private:
         std::list<std::function<bool(const gui::PopupRequestParams &)>> appDependentFilter;
+        /// non-owning pointer to existing stack - @see attachWindowsStack()
         app::WindowsStack *stack = nullptr;
 
       public:
+        virtual ~Filter() = default;
+
         void attachWindowsStack(app::WindowsStack *stack);
         void addAppDependentFilter(std::function<bool(const gui::PopupRequestParams &)> f);
         virtual bool isPermitted(const gui::PopupRequestParams &params) const;